staticaddr: move address.Parameters to script package#1133
staticaddr: move address.Parameters to script package#11330xfandom wants to merge 1 commit intolightninglabs:masterfrom
Conversation
The Parameters struct describes the keys, expiry and pkScript that define the static address script, so its natural home is the script package. Moving it there lets staticutil drop its dependency on the address package and lets callers reuse a single type alongside script.StaticAddress and script.NewStaticAddress. No behavior change. Closes lightninglabs#1056
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a targeted refactor to improve the codebase organization by relocating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by moving the Parameters struct from the staticaddr/address package to the staticaddr/script package. This change involves updating numerous files and tests to reference script.Parameters instead of address.Parameters, along with corresponding import adjustments. I have no feedback to provide.
Moves
Parametersfromstaticaddr/addresstostaticaddr/script. The struct only carries key material, expiry andpkScript— the inputs that define the script — so it sits more naturally next toStaticAddress/NewStaticAddressthan in theaddresspackage, andstaticaddr/staticutilno longer needs to importaddressjust to get this type.address.StoreandManagerstill own creation/persistence; only the type moves.Followup to #1043 (comment).
Closes #1056
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes — pure refactor, no behavior change.