Skip to content

staticaddr: move address.Parameters to script package#1133

Open
0xfandom wants to merge 1 commit intolightninglabs:masterfrom
0xfandom:refactor/1056-move-parameters-to-script
Open

staticaddr: move address.Parameters to script package#1133
0xfandom wants to merge 1 commit intolightninglabs:masterfrom
0xfandom:refactor/1056-move-parameters-to-script

Conversation

@0xfandom
Copy link
Copy Markdown

@0xfandom 0xfandom commented May 1, 2026

Moves Parameters from staticaddr/address to staticaddr/script. The struct only carries key material, expiry and pkScript — the inputs that define the script — so it sits more naturally next to StaticAddress / NewStaticAddress than in the address package, and staticaddr/staticutil no longer needs to import address just to get this type.

address.Store and Manager still own creation/persistence; only the type moves.

Followup to #1043 (comment).

Closes #1056

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes — pure refactor, no behavior change.

The Parameters struct describes the keys, expiry and pkScript that
define the static address script, so its natural home is the script
package. Moving it there lets staticutil drop its dependency on the
address package and lets callers reuse a single type alongside
script.StaticAddress and script.NewStaticAddress.

No behavior change.

Closes lightninglabs#1056
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a targeted refactor to improve the codebase organization by relocating the Parameters struct. By moving this type to the script package, it is now positioned alongside related logic, which simplifies package dependencies and clarifies ownership. This change is purely structural and does not alter existing functionality.

Highlights

  • Refactoring: Moved the Parameters struct from the staticaddr/address package to the staticaddr/script package to better align with the project's domain structure.
  • Dependency Cleanup: Removed unnecessary imports of the address package in several modules, including staticutil, deposit, and loopin, as they no longer need to reference the Parameters type from that package.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase by moving the Parameters struct from the staticaddr/address package to the staticaddr/script package. This change involves updating numerous files and tests to reference script.Parameters instead of address.Parameters, along with corresponding import adjustments. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move address.Parameters to script package and reuse it and this function.

1 participant