Skip to content

[Autofix][high] Alert #2: Time-of-check time-of-use filesystem race condition #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xengine-qyt wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Autofix][high] Alert #2: Time-of-check time-of-use filesystem race condition #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions XEngine_Source/StorageModule_Session/Session_Stroage/Session_DLStroage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,19 @@ bool CSession_DLStroage::Session_DLStroage_Insert(LPCXSTR lpszClientAddr, LPCXST
struct _xtstat st_FStat;

memset(&st_Client, '\0', sizeof(SESSION_STORAGEINFO));
int nRet = _xtstat(lpszFileDir, &st_FStat);
//先打开文件，再基于已打开句柄获取文件属性，避免TOCTOU
st_Client.pSt_File = _xtfopen(lpszFileDir, _X("rb"));
if (NULL == st_Client.pSt_File)
{
Session_IsErrorOccur = true;
Session_dwErrorCode = ERROR_STORAGE_MODULE_SESSION_OPENFILE;
return false;
}
int nRet = _xtfstat(_xtfileno(st_Client.pSt_File), &st_FStat);
if (-1 == nRet)
{
xtfclose(st_Client.pSt_File);
st_Client.pSt_File = NULL;
Session_IsErrorOccur = true;
Session_dwErrorCode = ERROR_STORAGE_MODULE_SESSION_OPENFILE;
return false;
Expand All @@ -166,13 +176,6 @@ bool CSession_DLStroage::Session_DLStroage_Insert(LPCXSTR lpszClientAddr, LPCXST
st_Client.xhToken = xhToken;
}
//填充下载信息
st_Client.pSt_File = _xtfopen(lpszFileDir, _X("rb"));
if (NULL == st_Client.pSt_File)
{
Session_IsErrorOccur = true;
Session_dwErrorCode = ERROR_STORAGE_MODULE_SESSION_OPENFILE;
return false;
}
//是否有范围
if ((nPosStart > 0) || (nPostEnd > 0))
{
Expand Down