Skip to content

[Autofix][high] Alert #74: File created without restricting permissions #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xengine-qyt wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Autofix][high] Alert #74: File created without restricting permissions #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion XEngine_Source/XEngine_StorageApp/StorageApp_UPLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
#include "StorageApp_Hdr.h"
#include <fcntl.h>
#include <unistd.h>
#include <sys/stat.h>
#include <stdio.h>

XHTHREAD XCALLBACK XEngine_UPLoader_HTTPThread(XPVOID lParam)
{
Expand Down Expand Up @@ -192,9 +196,20 @@ bool XEngine_Task_HttpUPLoader(LPCXSTR lpszClientAddr, LPCXSTR lpszMsgBuffer, in
return true;
}
//文件是否可写
FILE* pSt_File = _xtfopen(tszFileDir, _X("wb"));
int nFileFD = open(tszFileDir, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
if (nFileFD < 0)
{
st_HDRParam.bIsClose = true;
st_HDRParam.nHttpCode = 403;
HttpProtocol_Server_SendMsgEx(xhUPHttp, tszSDBuffer, &nSDLen, &st_HDRParam);
XEngine_Net_SendMsg(lpszClientAddr, tszSDBuffer, nSDLen, nNetType);
XLOG_PRINT(xhLog, XENGINE_HELPCOMPONENTS_XLOG_IN_LOGLEVEL_ERROR, _X("上传客户端:%s,准备上传文件:%s 失败,创建文件失败"), lpszClientAddr, tszFileDir);
return true;
}
FILE* pSt_File = fdopen(nFileFD, "wb");
if (NULL == pSt_File)
{
close(nFileFD);
st_HDRParam.bIsClose = true;
st_HDRParam.nHttpCode = 403;
HttpProtocol_Server_SendMsgEx(xhUPHttp, tszSDBuffer, &nSDLen, &st_HDRParam);
Expand Down