Skip to content

[Autofix][warning] Alert #75: Poorly documented large function #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xengine-qyt wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Autofix][warning] Alert #75: Poorly documented large function #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions XEngine_Source/StorageModule_Config/Config_Json/Config_Json.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,36 +42,46 @@ CConfig_Json::~CConfig_Json()
*********************************************************************/
bool CConfig_Json::Config_Json_File(LPCXSTR lpszConfigFile, XENGINE_SERVERCONFIG* pSt_ServerConfig)
{
// 初始化错误状态；函数开始默认“无错误”，出现任何失败分支时再设置错误码并返回。
Config_IsErrorOccur = false;

// 参数有效性检查：配置文件路径与输出结构体指针都不允许为空。
if ((NULL == lpszConfigFile) || (NULL == pSt_ServerConfig))
{
Config_IsErrorOccur = true;
Config_dwErrorCode = ERROR_XENGINE_BLOGIC_CONFIG_JSON_PARAMENT;
return false;
}

// JSON 解析相关对象：错误信息、根节点、Reader 构造器。
JSONCPP_STRING st_JsonError;
Json::Value st_JsonRoot;
Json::CharReaderBuilder st_JsonBuilder;

// 以二进制只读方式打开配置文件；打开失败视为参数/路径错误。
FILE* pSt_File = _xtfopen(lpszConfigFile, _X("rb"));
if (NULL == pSt_File)
{
Config_IsErrorOccur = true;
Config_dwErrorCode = ERROR_XENGINE_BLOGIC_CONFIG_JSON_PARAMENT;
return false;
}

// 读取文件内容到固定缓冲区，并在读取后立即关闭文件句柄。
XCHAR tszMsgBuffer[8192] = {};
size_t nRet = fread(tszMsgBuffer, 1, sizeof(tszMsgBuffer), pSt_File);
fclose(pSt_File);

// 执行 JSON 反序列化；解析失败时设置解析错误码并返回。
std::unique_ptr<Json::CharReader> const pSt_JsonReader(st_JsonBuilder.newCharReader());
if (!pSt_JsonReader->parse(tszMsgBuffer, tszMsgBuffer + nRet, &st_JsonRoot, &st_JsonError))
{
Config_IsErrorOccur = true;
Config_dwErrorCode = ERROR_XENGINE_BLOGIC_CONFIG_JSON_PARSE;
return false;
}

// 将 JSON 节点字段映射到服务配置结构体。
_tcsxcpy(pSt_ServerConfig->tszIPAddr, st_JsonRoot["tszIPAddr"].asCString());
pSt_ServerConfig->bDeamon = st_JsonRoot["bDeamon"].asInt();
pSt_ServerConfig->nCenterPort = st_JsonRoot["nCenterPort"].asInt();
Expand Down