Skip to content

[Autofix][warning] Alert #43: Poorly documented large function #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xengine-qyt wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Autofix][warning] Alert #43: Poorly documented large function #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions XEngine_Source/MQCore_ProtocolModule/ProtocolModule_Parse/ProtocolModule_Parse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,18 @@ CProtocolModule_Parse::~CProtocolModule_Parse()
*********************************************************************/
bool CProtocolModule_Parse::ProtocolModule_Parse_Websocket(LPCXSTR lpszMsgBuffer, int nMsgLen, XENGINE_PROTOCOLHDR* pSt_ProtocolHdr, XCHAR* ptszMsgBuffer, int* pInt_MsgLen)
{
// 初始化错误状态；本函数任何失败路径都会设置统一错误码后返回 false。
Protocol_IsErrorOccur = false;

// 基础参数校验：输入缓冲区必须有效。
if (NULL == lpszMsgBuffer)
{
Protocol_IsErrorOccur = true;
Protocol_dwErrorCode = ERROR_MQ_MODULE_PROTOCOL_PARAMENT;
return false;
}

// 第一步：将 WebSocket 文本消息解析为 JSON 根对象。
Json::Value st_JsonRoot;
JSONCPP_STRING st_JsonError;
Json::CharReaderBuilder st_ReaderBuilder;
Expand All @@ -75,6 +79,8 @@ bool CProtocolModule_Parse::ProtocolModule_Parse_Websocket(LPCXSTR lpszMsgBuffer
return false;
}

// 第二步：提取公共协议头字段（按字段是否存在进行兼容性读取）。
// pSt_ProtocolHdr 允许为空；为空时只执行消息体解析流程。
if (NULL != pSt_ProtocolHdr)
{
if (!st_JsonRoot["unOperatorType"].isNull())
Expand Down Expand Up @@ -103,6 +109,7 @@ bool CProtocolModule_Parse::ProtocolModule_Parse_Websocket(LPCXSTR lpszMsgBuffer
}
}

// 第三步：初始化消息体解析上下文，后续根据操作类型解析具体业务字段。
int nPos = 0;
*pInt_MsgLen = 0;
XENGINE_PROTOCOL_XMQ st_MQProtocol;
Expand Down