Skip to content

add LanOutlinedIcon to sistent icons#1553

Open
Daniel-1600 wants to merge 1 commit into
layer5io:masterfrom
Daniel-1600:feat/add-lan-outlined-icon
Open

add LanOutlinedIcon to sistent icons#1553
Daniel-1600 wants to merge 1 commit into
layer5io:masterfrom
Daniel-1600:feat/add-lan-outlined-icon

Conversation

@Daniel-1600
Copy link
Copy Markdown

Notes for Reviewers

This PR fixes #1514

Signed commits

  • Yes, I signed my commits.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the LanOutlinedIcon component and its local export. Feedback suggests exporting the icon from the main library entry point (src/icons/index.ts) to ensure it is accessible to consumers. Additionally, it is recommended to incorporate a default fill color and a title prop for better accessibility and internationalization support.

@@ -0,0 +1 @@
export { default as LanOutlinedIcon } from './LanOutlined'; No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The new icon is not currently exported from the main library entry point (src/icons/index.ts). To allow consumers to import LanOutlinedIcon directly from the icons package, please add an export statement for it in src/icons/index.ts.

Comment thread src/icons/LanOutlined/LanOutlined.tsx Outdated
Comment on lines +1 to +20
import { DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { IconProps } from '../types';

export const LanOutlinedIcon = ({
width = DEFAULT_WIDTH,
height = DEFAULT_HEIGHT,
...props
}: IconProps): JSX.Element => {
return (
<svg
width={width}
height={height}
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 24 24"
{...props}
>
<path d="M13,22h8v-7h-3v-4h-5V9h3V2H8v7h3v2H6v4H3v7h8v-7H8v-2h8v2h-3V22z M10,7V4h4v3H10z M9,17v3H5v-3H9z M19,17v3h-4v-3H19z" />
</svg>
);
};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the project's design system and improve accessibility, the DEFAULT_FILL constant should be used as a default value for the fill prop. Additionally, the title prop should be rendered within a <title> tag inside the SVG to support accessibility and internationalization, as per the general guidelines for shared components.

import { DEFAULT_HEIGHT, DEFAULT_WIDTH, DEFAULT_FILL } from '../../constants/constants';
import { IconProps } from '../types';

export const LanOutlinedIcon = ({
  width = DEFAULT_WIDTH,
  height = DEFAULT_HEIGHT,
  fill = DEFAULT_FILL,
  title,
  ...props
}: IconProps): JSX.Element => {
  return (
    <svg
      width={width}
      height={height}
      fill={fill}
      xmlns="http://www.w3.org/2000/svg"
      viewBox="0 0 24 24"
      {...props}
    >
      {title && <title>{title}</title>}
      <path d="M13,22h8v-7h-3v-4h-5V9h3V2H8v7h3v2H6v4H3v7h8v-7H8v-2h8v2h-3V22z M10,7V4h4v3H10z M9,17v3H5v-3H9z M19,17v3h-4v-3H19z" />
    </svg>
  );
};
References
  1. Avoid hardcoding UI strings in shared components. Expose these strings as configurable props to support internationalization (i18n) and localization.

@Daniel-1600 Daniel-1600 force-pushed the feat/add-lan-outlined-icon branch from 4717588 to fa81f2c Compare May 15, 2026 14:31
Signed-off-by: Daniel Mungai <chegedan699@gmail.com>
@Daniel-1600 Daniel-1600 force-pushed the feat/add-lan-outlined-icon branch from fa81f2c to 4620a1c Compare May 15, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add LanOutlinedIcon to Sistent

1 participant