Skip to content

fix: add duration and tags missing#1049

Merged
fitzergerald merged 1 commit into
layer5io:masterfrom
icoderarely:fix/video-duration-tags
May 19, 2026
Merged

fix: add duration and tags missing#1049
fitzergerald merged 1 commit into
layer5io:masterfrom
icoderarely:fix/video-duration-tags

Conversation

@icoderarely
Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1048 by normalizing video metadata so duration/tags render consistently across cards.
Adds/updates duration and tags for Publishing Designs, Meshery Playground Teaser, and Birth of Kanvas Logo entries.

2026-05-16.14-54-28.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates video metadata by adding tags and duration fields across several files and correcting a typo in the duration key for the 'publish-design' video. The review feedback identifies a potential UI issue where the 'MM:SS' duration format will be incorrectly displayed with a hardcoded ' min' suffix (e.g., '0:16 min') due to existing template logic. It is recommended to either provide the duration as a numeric value in minutes or update the site templates to handle the time format correctly.

Comment thread content/en/videos/advanced/advanced/birth-of-kanvas-logo.md
Comment thread content/en/videos/features/meshery/meshery-teaser.md
Comment thread content/en/videos/getting-started/comments/publish-design.md
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-05-19 19:22 UTC

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

@icoderarely Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@rishiraj38
Copy link
Copy Markdown
Member

LGTM !!!!

@fitzergerald fitzergerald merged commit 50426ec into layer5io:master May 19, 2026
4 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented May 19, 2026

        Thank you for contributing to the Layer5 community! 🎉 \ \ Congrats! \ \         ⭐ Please leave a star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Advanced tutorial cards are missing duration and tag metadata

4 participants