Conversation
|
@cursor review |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk-common size report |
aca1b27 to
a1477d5
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a1477d5. Configure here.
a1477d5 to
7197b4e
Compare
ec8455c to
964bab2
Compare
| "author": "LaunchDarkly", | ||
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@launchdarkly/js-sdk-common": "2.24.4", |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@launchdarkly/js-sdk-common": "2.24.4", | ||
| "@launchdarkly/openfeature-js-server-common": "workspace:^" |
There was a problem hiding this comment.
Can we use whatever version number is in here instead of workspace?
| "@openfeature/server-sdk": "^1.16.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@launchdarkly/node-server-sdk": "9.10.12", |
There was a problem hiding this comment.
🟡 Dev dependency version mismatch: @launchdarkly/node-server-sdk pinned to 9.10.12 instead of workspace version 9.10.14
The new package pins @launchdarkly/node-server-sdk at 9.10.12 in devDependencies, but the workspace version at packages/sdk/server-node/package.json is 9.10.14. Every other package in the repo that lists this as a devDependency uses 9.10.14 (e.g., packages/store/node-server-sdk-redis/package.json, packages/store/node-server-sdk-dynamodb/package.json, packages/telemetry/node-server-sdk-otel/package.json). In Yarn 3 workspaces, an exact pinned version that doesn't match the workspace version will attempt to resolve from the npm registry instead of using the local workspace package, which can cause build/test failures or use a stale published version.
| "@launchdarkly/node-server-sdk": "9.10.12", | |
| "@launchdarkly/node-server-sdk": "9.10.14", |
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bdf38a1. Configure here.
| "@openfeature/server-sdk": "^1.16.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@launchdarkly/node-server-sdk": "9.10.12", |
There was a problem hiding this comment.
Stale devDependency version won't resolve to workspace package
Medium Severity
The devDependencies entry for @launchdarkly/node-server-sdk is pinned to 9.10.12, but the actual workspace version is 9.10.14. In Yarn 3, this exact-version mismatch prevents resolution to the local workspace package, causing Yarn to fetch the older version from npm instead. Every other package in this monorepo (e.g., node-server-sdk-otel, examples) correctly references 9.10.14. This will break the local development workflow once real implementation and tests are added.
Reviewed by Cursor Bugbot for commit bdf38a1. Configure here.


NOTE: the important discussion on this PR is whether or not we are going to major version our OF node server provider.
Currently, we should be preserving backward compatibility with the existing package, but there are significant implementation changes.
This PR is also blocked behind releasing the common module
Note
Low Risk
Low risk: changes are mostly build/release scaffolding and workspace wiring, with no provider runtime implementation yet; main risk is unintended effects on monorepo build/release configuration.
Overview
Adds initial scaffolding for a new experimental package,
@launchdarkly/openfeature-node-server, including build/test tooling (tsup,tsconfig,jest) plus placeholdersrc/index.ts, README, and license.Updates monorepo wiring to recognize and publish the package (root workspaces, TS project references,
release-pleaseconfig/manifest), and exportstranslateContextfromopenfeature-server-common. Minor housekeeping updates.gitignoreand reorders a devDependency entry inserver-ai-vercel.Reviewed by Cursor Bugbot for commit bdf38a1. Bugbot is set up for automated code reviews on this repo. Configure here.