Conversation
f87a58e to
df6cb7d
Compare
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/browser size report |
|
@cursor review |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "extends": "./.svelte-kit/tsconfig.json", | |||
| "extends": "./tsconfig.eslint.json", | |||
There was a problem hiding this comment.
Svelte tsconfig.json extends wrong base config file
High Severity
The tsconfig.json now extends ./tsconfig.eslint.json instead of ./.svelte-kit/tsconfig.json. The .svelte-kit/tsconfig.json is generated by SvelteKit (via svelte-kit sync) and contains critical path aliases (like $lib, $app) and other settings required for proper TypeScript compilation and IDE support. The tsconfig.eslint.json is a simplified config intended only for ESLint's TypeScript parser. This change breaks the SvelteKit TypeScript integration for builds and IDE tooling.
Reviewed by Cursor Bugbot for commit df6cb7d. Configure here.
df6cb7d to
f082d51
Compare
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f082d51. Configure here.
| // TODO: a lot of our examples fail this one, will need to check | ||
| 'import-x/no-unresolved': 'off', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Console override commented out contradicting section intent
Medium Severity
The config section is titled "allow console" for examples, contract-tests, and tooling packages, but 'no-console': 'off' on line 196 is commented out. Combined with the newly introduced 'no-console': 'error' base rule (line 142), this means console usage in these directories will now trigger lint errors unless individual files have their own eslint-disable comment. Files in packages/tooling/ that use console without file-level disables will now fail linting.
Reviewed by Cursor Bugbot for commit f082d51. Configure here.
f082d51 to
c0d60d5
Compare


This PR will update eslint to version 9 with the following changes:
eslint.config.mjsAs a result, there are some deprecated/updated recommendations. In general, I tried to go with the recommendations as much as possible, the deviations and notible changes are:
no-redeclarerule is deprecated because typescript compilers should catch these cases nowexplicit-anyis disabled for now because we have too many violationsno-param-reassignis a bit more permissible than before - now, it will let object field modifications but not whole value replacements.max-classes-per-fileis not re-enabled (recommendations did not enable it)class-method-use-thisis off due to too many violationsI did not include any style rules as those will be introduced in a separate PR.
Note
Medium Risk
Tooling-only change but touches many workspaces and eslint rules/ignores, so it may break local/CI linting behavior or start flagging new violations until configs stabilize.
Overview
Moves from legacy
.eslintrc/.eslintignoreto a root ESLint v9 flat config ineslint.config.mjs, consolidating ignore patterns, TypeScript project settings, import resolution, and jest/test overrides.Updates root and workspace
package.jsonfiles to ESLint v9-compatible deps (@eslint/js,typescript-eslint,eslint-plugin-import-x,eslint-import-resolver-typescript,globals, newereslint-plugin-jest) and simplifies lint scripts toeslint ./eslint . --fix.Applies small codebase-wide lint cleanups/overrides (removing many inline
eslint-disablecomments, adding a few targeted disables, and tweaking TS/ESLint-related typing suppressions) and drops package-local ESLint configs that are now covered by the root configuration.Reviewed by Cursor Bugbot for commit f082d51. Bugbot is set up for automated code reviews on this repo. Configure here.