Skip to content

feat: recommend keywords for minutes#944

Open
zhangjun-bytedance wants to merge 1 commit into
mainfrom
feat/minutes_fix_keywords
Open

feat: recommend keywords for minutes#944
zhangjun-bytedance wants to merge 1 commit into
mainfrom
feat/minutes_fix_keywords

Conversation

@zhangjun-bytedance
Copy link
Copy Markdown
Collaborator

@zhangjun-bytedance zhangjun-bytedance commented May 18, 2026

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark xxx command works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Updated query routing guidelines for theme, keyword, topic, and tag-based searches to improve result retrieval consistency and fallback handling.

Review Change Stack

Co-authored-by: Cursor <cursoragent@cursor.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 18, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2bccfa2c-a464-4c98-9e76-aa7b1d9c4a16

📥 Commits

Reviewing files that changed from the base of the PR and between 4b721c0 and 7561dbb.

📒 Files selected for processing (1)
  • skills/lark-minutes/SKILL.md

📝 Walkthrough

Walkthrough

The PR updates documentation in skills/lark-minutes/SKILL.md to establish a keywords-first routing strategy for theme and tag queries: call minutes minutes get to read the keywords field, and fall back to vc +notes --minute-tokens when keywords is empty. The guidance is reflected across instruction text, a resource relationship diagram, and the routing rules list.

Changes

Keywords routing guidance in lark-minutes documentation

Layer / File(s) Summary
Keywords routing guidance across instruction, diagram, and rules
skills/lark-minutes/SKILL.md
Routing instructions for theme/keywords/topics/tags queries now use minutes minutes get to read keywords first, with fallback to vc +notes --minute-tokens when empty. Resources relationship diagram includes Keywords mapping, and routing rules list reflects the same keywords-first flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • larksuite/cli#591: Broader routing-semantic changes in the lark-minutes/vc +notes vs minutes minutes get area that align with this PR's keywords-first routing guidance.

Suggested labels

domain/vc

Suggested reviewers

  • zhaoleibd

Poem

🐇 A minute's keywords now lead the way,
When themes and tags have words to say—
First call the API's kindly store,
Then notes unlock what hides before!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description uses only template placeholders with no actual content filled in—Summary, Changes, and Test Plan sections are empty or contain generic 'Change 1/2' text, leaving reviewers without concrete details about the modification. Fill in the Summary with the motivation (e.g., routing queries for keywords/themes), list actual Changes (e.g., updated routing guidance and Resources diagram), and confirm Test Plan steps completed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: recommend keywords for minutes' clearly and specifically describes the main change: adding keyword recommendation functionality for minutes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/minutes_fix_keywords

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.47%. Comparing base (2419524) to head (7561dbb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files         562      562           
  Lines       51871    51871           
=======================================
  Hits        34482    34482           
  Misses      14499    14499           
  Partials     2890     2890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@7561dbb2ea88df27b27a7d33d56601eea3ba09c4

🧩 Skill update

npx skills add larksuite/cli#feat/minutes_fix_keywords -y -g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants