webhook/testing: replace deprecated autoscaling/v2beta1 with autoscaling/v2#3353
Conversation
Signed-off-by: Anitha Natarajan <anataraj@redhat.com>
|
|
|
Welcome @anithapriyanatarajan! It looks like this is your first PR to knative/pkg 🎉 |
|
Hi @anithapriyanatarajan. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3353 +/- ##
=======================================
Coverage 74.87% 74.87%
=======================================
Files 189 189
Lines 8347 8347
=======================================
Hits 6250 6250
Misses 1853 1853
Partials 244 244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
🗑️ Replace deprecated
autoscaling/v2beta1imports with stableautoscaling/v2inwebhook/testing/listers.gok8s.io/apiv0.36.0 (Kubernetes 1.36) deletedk8s.io/api/autoscaling/v2beta1andk8s.io/client-go/listers/autoscaling/v2beta1, which were deprecated since Kubernetes 1.12 and server-removed in Kubernetes 1.26.The trigger for this PR is because Go resolves a single version of
k8s.io/apiacross the entire module graph, any project that depends on bothknative/pkgandk8s.io/api >= v0.36.0hits a hard build failure:k8s.io/api/autoscaling/v2beta1: module k8s.io/api@v0.36.0 found, but does not contain package k8s.io/api/autoscaling/v2beta1Example case : Experienced this issue while upgrading k8s.io/client-go to 0.36.0(https://github.com/tektoncd/operator/blob/main/go.mod#L45) to address kubernetes/client-go@ea7a7e7 . We are blocked because of this.
/kind removal
Release Note