Skip to content

change(web): simplify mapWhitespacedTokenization requirements 🚂#15919

Draft
jahorton wants to merge 1 commit into
refactor/web/expose-suggestion-root-tokenizationfrom
change/web/abstract-whitespace-tokenization-mapping
Draft

change(web): simplify mapWhitespacedTokenization requirements 🚂#15919
jahorton wants to merge 1 commit into
refactor/web/expose-suggestion-root-tokenizationfrom
change/web/abstract-whitespace-tokenization-mapping

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

@jahorton jahorton commented May 6, 2026

To better handle inputs that shift the word-boundary in some custom models and models released before Keyman 14.0, this PR provides generalized re-use of the whitespace-based token-transition algorithm used for our most prominently-supported models.

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot Bot commented May 6, 2026

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot Bot changed the title change(web): simplify mapWhitespacedTokenization requirements change(web): simplify mapWhitespacedTokenization requirements 🚂 May 6, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S28 milestone May 6, 2026
@github-actions github-actions Bot added the change Minor change in functionality, but not new label May 6, 2026
@jahorton jahorton force-pushed the feat/web/multi-token-predict-core branch from 6d11477 to fdd65c0 Compare May 7, 2026 18:21
@jahorton jahorton force-pushed the change/web/abstract-whitespace-tokenization-mapping branch from 7539b3e to 6c1170d Compare May 7, 2026 18:22
@keyman-server keyman-server modified the milestones: A19S28, A19S29 May 11, 2026
@jahorton jahorton force-pushed the change/web/abstract-whitespace-tokenization-mapping branch from da7359e to a800a12 Compare May 15, 2026 18:30
@jahorton jahorton changed the base branch from feat/web/multi-token-predict-core to change/web/simplify-predict-calls May 15, 2026 18:30
@jahorton jahorton force-pushed the change/web/abstract-whitespace-tokenization-mapping branch 2 times, most recently from c12cef9 to 5f4d1ee Compare May 19, 2026 18:12
@jahorton jahorton changed the base branch from change/web/simplify-predict-calls to refactor/web/expose-suggestion-root-tokenization May 19, 2026 18:12
@jahorton jahorton force-pushed the refactor/web/expose-suggestion-root-tokenization branch from 3227268 to 1368431 Compare May 21, 2026 22:02
To better handle inputs that shift the word-boundary in some custom models and models released before Keyman 14.0, this PR provides generalized re-use of the whitespace-based token-transition algorithm used for our most prominently-supported models.

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the change/web/abstract-whitespace-tokenization-mapping branch from 5f4d1ee to 7eb3030 Compare May 21, 2026 22:13
Comment on lines +615 to +619
export interface ContextTokenLike {
exampleInput: string;
isPartial?: boolean;
sourceRangeKey?: string;
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve: this is separate (at present) from one added earlier in #15992.

@keyman-server keyman-server modified the milestones: A19S29, A19S30 May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change Minor change in functionality, but not new epic-autocorrect web/predictive-text/ web/

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants