Skip to content

fix macos local dev#249

Merged
Sayan- merged 1 commit into
mainfrom
sayan/fix-macos-local
May 22, 2026
Merged

fix macos local dev#249
Sayan- merged 1 commit into
mainfrom
sayan/fix-macos-local

Conversation

@Sayan-
Copy link
Copy Markdown
Contributor

@Sayan- Sayan- commented May 22, 2026

life happens fast


Note

Medium Risk
Changes the build/run platform for the chromium Docker images, which can affect local dev behavior and may break workflows that relied on native arm64 images without explicitly overriding the platform.

Overview
For the chromium-headful and chromium-headless images, the build scripts now pass --platform "$DOCKER_PLATFORM" to docker build, and the run scripts include --platform "$DOCKER_PLATFORM" in docker run.

ensure-common-build-run-vars.sh introduces DOCKER_PLATFORM (defaulting to linux/amd64) with rationale for Chrome-for-Testing on Apple Silicon, allowing overrides for custom arm64 images.

Reviewed by Cursor Bugbot for commit 2689339. Bugbot is set up for automated code reviews on this repo. Configure here.

@firetiger-agent
Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: PR title and description suggest local development fixes with no indication of changes to API endpoints or Temporal workflows.

To monitor this PR anyway, reply with @firetiger monitor this.

@Sayan- Sayan- merged commit f99f9ed into main May 22, 2026
9 checks passed
@Sayan- Sayan- deleted the sayan/fix-macos-local branch May 22, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants