fix macos local dev#249
Merged
Merged
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR title and description suggest local development fixes with no indication of changes to API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
hiroTamada
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
life happens fast
Note
Medium Risk
Changes the build/run platform for the chromium Docker images, which can affect local dev behavior and may break workflows that relied on native
arm64images without explicitly overriding the platform.Overview
For the
chromium-headfulandchromium-headlessimages, the build scripts now pass--platform "$DOCKER_PLATFORM"todocker build, and the run scripts include--platform "$DOCKER_PLATFORM"indocker run.ensure-common-build-run-vars.shintroducesDOCKER_PLATFORM(defaulting tolinux/amd64) with rationale for Chrome-for-Testing on Apple Silicon, allowing overrides for customarm64images.Reviewed by Cursor Bugbot for commit 2689339. Bugbot is set up for automated code reviews on this repo. Configure here.