live view loading: replace logo pulse with slide bar#248
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR only modifies UI components (connect.vue and about.vue) with no changes to API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
masnwilliams
requested review from
archandatta
and removed request for
archandatta
masnwilliams
changed the title
rgarcia
approved these changes
May 22, 2026
Keeps the filename as logo.svg so the metro-api browserproxy logo asset prefix match (img/logo.) still routes through the enterprise HIDDEN/CUSTOM logo override logic. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the zoom/pulse animation on the kernel logo shown while the live view client is connecting. The animation triggered on every live view session (not just kiosk mode). Now shows the stacked logo (white variant) above a thin sliding loading bar — matches the loading style used in the mcp-server select-org page.
Affects
connect.vue(initial connection splash) andabout.vue(about modal loading state).Preview
https://htmlpreview.github.io/?https://gist.githubusercontent.com/masnwilliams/2f7e13b3327344b4219f293225c35539/raw/preview.html (toggle button in top-right flips between old and new)
Test plan
Note
Low Risk
Low risk visual-only change to the loading/connecting UI; no behavioral, auth, or data-flow changes.
Overview
Updates the live-view connection splash (
connect.vue) and about modal loading state (about.vue) to show a stacked logo with a thin animated sliding loading bar instead of the prior pulsing/zoom logo animation.Also changes the bundled
logo.svgfill color from green to white to match the new loading treatment.Reviewed by Cursor Bugbot for commit 8e699ca. Bugbot is set up for automated code reviews on this repo. Configure here.