Skip to content

Use SAST fast diff mode config option if applicable#745

Open
attiasas wants to merge 1 commit intojfrog:devfrom
attiasas:sast_diff_mode_config_option
Open

Use SAST fast diff mode config option if applicable#745
attiasas wants to merge 1 commit intojfrog:devfrom
attiasas:sast_diff_mode_config_option

Conversation

@attiasas
Copy link
Copy Markdown
Collaborator

@attiasas attiasas commented May 4, 2026

feat(sast): respect SAST fast diff mode from config profile

Depends on:

Description

This change wires the JAS SAST runner to honor SAST fast diff mode from the config profile (SastScannerConfig.EnableFastDiffMode) when determining changed-files mode, in addition to the existing CLI/audit SastChangedFilesMode flag. The JasRunnerParams field for the changed-file list is renamed from SastChangedFiles to ChangedFiles and is passed through from audit consistently.

Changes

  • commands/audit/audit.go: pass ChangedFiles into JAS params (renamed from SastChangedFiles).
  • jas/runner/jasrunner.go: rename JasRunnerParams.SastChangedFilesChangedFiles; set SAST ChangedFilesMode to SastChangedFilesMode || config profile EnableFastDiffMode (with nil-safe access on ConfigProfile.Modules[0].ScanConfig).

Testing

  • Not shown in the diff. Before merge: go vet ./..., go test ./..., and a manual audit/SAST run with a config profile that sets fast diff mode to confirm changed-files behavior matches expectations.

@attiasas attiasas requested a review from a team May 4, 2026 08:05
@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels May 4, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants