Updated logic for setup of artifactory instance when url is given#30
Open
naveenku-jfrog wants to merge 1 commit intomainfrom
Open
Updated logic for setup of artifactory instance when url is given#30naveenku-jfrog wants to merge 1 commit intomainfrom
naveenku-jfrog wants to merge 1 commit intomainfrom
Conversation
naveenku-jfrog
requested review from
bhanurp and
sverdlov93
and removed request for
sverdlov93
bhanurp
requested changes
Apr 28, 2026
| echo "JFROG_TESTS_IS_EXTERNAL=true" >> $GITHUB_ENV | ||
| else | ||
| ~/go/bin/local-rt-setup --connection-timeout-seconds "${RT_CONNECTION_TIMEOUT_SECONDS}" | ||
| go install github.com/jfrog/jfrog-testing-infra/local-rt-setup@${RT_SETUP_VERSION} |
Contributor
There was a problem hiding this comment.
lets add a validation for RTLIC here since input is not made as non mandatory.
Author
There was a problem hiding this comment.
RTLIC is present as secret in jfrog-cli-workflows. I don't think we should add validation of RTLIC here, since this action is just for installing and updating env variables here.
Author
There was a problem hiding this comment.
We have added RTLIC as secret in jfrog-cli-workflows, adding RTLIC validation step here is not useful. RTLIC is optional for jfrog-cli workflows tests, so making it as a validation step doesn't look good.
Contributor
There was a problem hiding this comment.
refer to changes rtlic is mandatory earlier
inputs:
RTLIC:
description: "Local Artifactory License."
required: true
bhanurp
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Updated logic for setup of artifactory instance when url is given
Why: We have a need of setting up artifactory instance in many tests, but not with local instance.