Improve extension matching and webgl extensions support#2728
Improve extension matching and webgl extensions support#2728riccardobl merged 6 commits intojMonkeyEngine:masterfrom
Conversation
riccardobl
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates GLRenderer to improve OpenGL extension detection by adding a flexible hasExtension method that handles GL_ prefixes automatically and introducing a hasAnyExtension helper. These changes are applied across various capability checks to better support WebGL and different OpenGL implementations. I have identified a logic error in the new hasExtension method where it may incorrectly append a prefix to an already prefixed string, and I have suggested a simplification for the redundant extension checks in the BPTC compression logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
This reverts commit 503d505.
1 participant
This PR improves extension matching, adds webgl extensions as well and fixes some extensions misuse