Skip to content

Windows bonded BLE devices, connect via MAC#105

Open
intercreate-gab wants to merge 9 commits intomainfrom
feat/windows_ble_connection
Open

Windows bonded BLE devices, connect via MAC#105
intercreate-gab wants to merge 9 commits intomainfrom
feat/windows_ble_connection

Conversation

@intercreate-gab
Copy link
Copy Markdown
Collaborator

This PR resolves connection to bonded devices without advertising on windows.

Copy link
Copy Markdown
Collaborator

@JPHutchins JPHutchins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Before proceeding, I'd like for you to take a look at this Bleak feature that was merged yesterday to see if it accomplishes the same without any workarounds: hbldh/bleak#1979

We'd need to figure out ordering in the connect method. If the get_connected_devices() method is fast, then we could always run it first. If not, we'd have to consider racing it again the find_device_by_address().

To test, you probably need to point the bleak version lock at github rather than a released version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants