Migrate tokens#2532
Open
joyenjoyer wants to merge 3 commits intomasterfrom
Open
Conversation
|
matyasf
requested changes
Apr 29, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
Looks good, just some small changes
| const __dirname = dirname(__filename) | ||
| // @ts-ignore -- package ships JS source without type declarations | ||
| import { themeTokens } from '@instructure/instructure-design-tokens' | ||
| import setupThemes from './buildThemes/setupThemes.ts' |
Collaborator
There was a problem hiding this comment.
This line raises a TS error for me:
TS5097: An import path can only end with a .ts extension when allowImportingTsExtensions is enabled.
HerrTopi
approved these changes
Apr 29, 2026
matyasf
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE DON'T MERGE IT, WE ARE WAITING FOR DESIGNERS TO FINISH TOKENS CHANGES ON A SEPARATE BRANCH AND PERSONAL ACCESS TOKEN APPROVAL FOR SERVICE ACCOUNT
Summary
ui-scriptsinto the external@instructure/instructure-design-tokenspackage and consumes them via its published APIbuild-themes,setupThemes, andgenerateSemanticsto work natively with the nested token object instead of a flat slash-keyed map, TS typing can be improved laterTest Plan
To verify the new pipeline produces identical output to the old one:
master, runpnpm run build:themes, copy the output:cp -r packages/ui-themes/src/themes/newThemeTokens /tmp/newThemeTokens-masterpnpm install && pnpm run build:themesdiff -r /tmp/newThemeTokens-master packages/ui-themes/src/themes/newThemeTokens/— should be emptypnpm run bootstrapand confirm no TypeScript errorsJira Reference
Fixes INSTUI-5002
🤖 Generated with Claude Code