Conversation
|
joyenjoyer
approved these changes
Apr 29, 2026
Contributor
joyenjoyer
left a comment
joyenjoyer
left a comment
There was a problem hiding this comment.
good job, works well for me in Firefox, Chrome and Safari
matyasf
requested changes
Apr 29, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
looks good, just documentation is missing
| > | ||
| <div css={styles?.container}> | ||
| <input | ||
| data-checked={indeterminate ? 'mixed' : this.checked} |
Collaborator
There was a problem hiding this comment.
Can you please write in Checkboxes and CheckboxGroup's Readme about this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4902
ISSUE:
TEST PLAN:
<input>element in Checkbox v11.7, the data-checked attribute value should reflect the checked state (true, false, mixed) and upgrade accordingly in the checkbox and toggle variant too