Skip to content

fix(ui-tabs): fix tabs panel layout when unmountOnExit is false#2526

Merged
ToMESSKa merged 1 commit intomasterfrom
INSTUI-4994-11-7-tabs-with-unmount-on-exit-false-is-broken
Apr 28, 2026
Merged

fix(ui-tabs): fix tabs panel layout when unmountOnExit is false#2526
ToMESSKa merged 1 commit intomasterfrom
INSTUI-4994-11-7-tabs-with-unmount-on-exit-false-is-broken

Conversation

@ToMESSKa
Copy link
Copy Markdown
Contributor

@ToMESSKa ToMESSKa commented Apr 24, 2026 •
edited
Loading

INSTUI-4994

ISSUE:

  • tabs panel layout looks broken when unmountOnExit is set to false: isHidden state wasn't passed properly so display: none was never applied to non-selected panels

TEST PLAN:

  • check the example under the Persisting the selected tab heading in Tabs v.11.7
  • the layout should not be broken on the second, third and fourth tab, there should be no extra space above the tabpanel content
  • the test should fail when the fix is reversed
image

@ToMESSKa ToMESSKa self-assigned this Apr 24, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026 •
edited
Loading

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-28 14:13 UTC

@ToMESSKa ToMESSKa force-pushed the INSTUI-4994-11-7-tabs-with-unmount-on-exit-false-is-broken branch from 34b9fd6 to d0aafec Compare April 24, 2026 14:54
@ToMESSKa ToMESSKa requested review from git-nandor and matyasf April 24, 2026 15:45
@ToMESSKa ToMESSKa merged commit 826ff62 into master Apr 28, 2026
10 of 12 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4994-11-7-tabs-with-unmount-on-exit-false-is-broken branch April 28, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matyasf matyasf matyasf approved these changes

@git-nandor git-nandor git-nandor approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ToMESSKa @matyasf @git-nandor