v6 major release#2552
Open
aryamohanan wants to merge 32 commits into
Open
Conversation
…nce (#2430) - Created a utility file for shared configuration helpers. - Moved and renamed normalizeSingleValue to resolveNumericConfig within the new utility module.
…v variable (#2431) BREAKING CHANGE: - The environment variable INSTANA_DEV_MIN_DELAY_BEFORE_SENDING_SPANS has been removed. - Please use INSTANA_TRACING_TRANSMISSION_DELAY instead.
Restructured the existing tests to improve logical grouping
- Normalization previously operated on a pre-filled in-code user config, making it unclear whether values were already present or resolved later(from env, in-code, or defaults). - This change separated input from the resulting config, making value resolution explicit and easier to follow.
BREAKING CHANGE: environment config now overrides in-code configuration. Enforces consistent precedence: env > in-code Previously inconsistent behavior is now fixed. This may impact setups relying on the old precedence. ref https://jsw.ibm.com/browse/INSTA-80965
ProcessControls was setting INSTANA_TRACING_DISABLE=false for all tests where tracingEnabled=true (the default). According to the precedence rules in disable.js, when INSTANA_TRACING_DISABLE is set to 'false', it takes precedence over INSTANA_TRACING_DISABLE_INSTRUMENTATIONS and INSTANA_TRACING_DISABLE_GROUPS, preventing granular disable configurations from working in tests. This caused logging integration tests to fail when trying to disable specific instrumentations using INSTANA_TRACING_DISABLE_INSTRUMENTATIONS or INSTANA_TRACING_DISABLE_GROUPS. Changed ProcessControls to only set INSTANA_TRACING_DISABLE='true' when tracingEnabled=false, and not set it at all when tracingEnabled=true, allowing other disable environment variables to work correctly.
…olean Fixed normalizeTracingEnabled to only use INSTANA_TRACING_DISABLE for the tracing.enabled config when the env var value is 'true' or 'false'. When it contains instrumentation/group names (e.g., 'logging'), it's now handled by the separate disable normalizer
BREAKING CHANGE: agent config now applies based on the precedence. Enforces consistent precedence: env > in-code > agent config > default Previously inconsistent behavior is now fixed. This may impact setups relying on the old precedence.
#2506) External config updates now deep-merge nested plain objects into the existing normalized config instead of replacing them at the top level.
--------- Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
The configuration precedence is updated. The new configuration precedence order is:
environment variables > in-code configuration > agent configuration > default valuessee: #2432
INSTANA_DEV_MIN_DELAY_BEFORE_SENDING_SPANSis removed. UseINSTANA_TRACING_TRANSMISSION_DELAYinstead.public docs any updates: https://github.ibm.com/instana/docs/pull/19776/files
ref https://jsw.ibm.com/browse/INSTA-82558
Before release
After release