chore: fixed mariadb url capture for esm#2551
Merged
Merged
Conversation
kirrg001
reviewed
May 15, 2026
| }; | ||
| const isGetterExport = !!Object.getOwnPropertyDescriptor(mariadbAdapterModule, 'PrismaMariaDb')?.get; | ||
| // CJS: PrismaMariaDb is a getter property | ||
| if (isGetterExport) { |
Contributor
There was a problem hiding this comment.
I think something is wrong here.
CJS e.g.
Original vs Modified
{ PrismaMariaDb: [Getter] }
{ PrismaMariaDb: [class InstanaPrismaMariaDb extends PrismaMariaDbAdapterFactory] }
I expect:
{ InstanaPrismaMariaDb: [Getter] }
Contributor
Author
There was a problem hiding this comment.
Updated to preserve the original getter semantics
kirrg001
reviewed
May 15, 2026
| }; | ||
| } | ||
| // ESM: PrismaMariaDb is a direct export | ||
| mariadbAdapterModule.PrismaMariaDb = InstanaPrismaMariaDb; |
kirrg001
requested changes
May 15, 2026
kirrg001
approved these changes
May 15, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESM tests were failing on main due to prisma mariadb adapter not capturing url for ESM apps.