chore: bump signet-storage family to 0.8 (workspace 0.18.0)#143
Open
rswanson wants to merge 2 commits into
Open
chore: bump signet-storage family to 0.8 (workspace 0.18.0)#143rswanson wants to merge 2 commits into
rswanson wants to merge 2 commits into
Conversation
Bumps the workspace to 0.18.0 and updates the signet-storage family of crates (signet-storage, signet-cold, signet-hot, signet-hot-mdbx, signet-cold-mdbx, signet-storage-types) from 0.7 to 0.8. This is a breaking upstream release, so the rest of the signet ecosystem (signet-bundle, signet-types, signet-evm, signet-zenith, etc.) and init4-bin-base also move forward to coherent versions: 0.16 -> 0.17, init4-bin-base 0.19.1 -> 0.20.0. Code migration for the new storage API: - UnifiedStorage<H> -> UnifiedStorage<H, B> (second generic for the cold-storage backend). The B parameter propagates through every type that holds the unified handle: StorageRpcCtx, SignetNode, SignetNodeBuilder, and all rpc endpoint signatures. - ColdStorageReadHandle -> ColdStorage<B> (read handle is now a cheap clone of the cold storage handle itself). - ColdStorageTask::spawn / ColdStorageHandle removed; use ColdStorage::new or UnifiedStorage::spawn. - append_blocks and unwind_above on UnifiedStorage are now async. - signet-types 0.17 wraps headers in SignetHeaderV1. Sites that used Sealed<Header> directly now bridge via SignetHeaderV1::new_unchecked and SignetHeaderV1::into_inner. - node-config exposes a NodeColdBackend type alias that resolves to EitherCold when SQL features are on and to MdbxColdBackend otherwise, so callers can name the cold side concretely without caring which runtime backend was chosen. Pre-push checks (fmt, clippy --all-features, clippy --no-default-features, doc) all pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The `# Examples` block on `SignetNodeBuilder` referenced `UnifiedStorage<H, B>` after the storage-0.8 migration but only declared `H` on the `example` fn, so `cargo test --doc` failed to compile. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signet-storagefamily (storage, cold, hot, hot-mdbx, cold-mdbx, storage-types) from 0.7 → 0.8. Because 0.8 is a breaking upstream release with transitive constraints, this also bumpsinit4-bin-base0.19.1 → 0.20.0 and the rest of thesignet-*ecosystem (bundle, constants, evm, extract, types, tx-cache, zenith, journal, test-utils) 0.16 → 0.17. Workspace version goes 0.17.2 → 0.18.0 (minor, not patch — this is a breaking API change for downstream consumers ofsignet-node/signet-rpc).UnifiedStorage<H>is nowUnifiedStorage<H, B>whereB: ColdStorageBackend. TheBgeneric propagates throughStorageRpcCtx,SignetNode,SignetNodeBuilder, and every RPC endpoint signature.ColdStorageReadHandleis gone;cold_reader()now returnsColdStorage<B>(a cheap clone).ColdStorageTask::spawnremoved — useColdStorage::neworUnifiedStorage::spawn.UnifiedStorage::append_blocks/unwind_aboveare nowasync.signet-types0.17 wraps headers inSignetHeaderV1; sites that handledSealed<Header>directly now bridge viaSignetHeaderV1::new_unchecked/SignetHeaderV1::into_inner.signet-node-configexposes aNodeColdBackendtype alias (EitherColdwith SQL features,MdbxColdBackendotherwise) so callers can name the cold backend concretely without caring which runtime backend is active.Test plan
cargo +nightly fmt --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo clippy --workspace --all-targets --no-default-features -- -D warningsRUSTDOCFLAGS=\"-D warnings\" cargo doc --workspace --no-deps🤖 Generated with Claude Code