Refactor bot runtime and withdrawal selection#34
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the bot application by migrating several utility functions and logic to shared packages. Specifically, it introduces the @ickb/node-utils dependency to handle logging, error management, and environment parsing, while delegating deposit selection and cleanup logic to the @ickb/sdk. Additionally, the PR replaces manual cell collection with the collectCompleteScan utility and removes redundant local implementations and tests. I have no feedback to provide.
Member
Author
|
LGTM Phroi %187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Changes
@ickb/node-utilsfor public client creation, signer lock ordering, loop sleep, JSON logging, and timeout handling.@ickb/node-utils.