Skip to content

Markdownlint: more rules vol. 2#3148

Open
mnocon wants to merge 3 commits into
5.0from
markdownlint-more-rules-even-more
Open

Markdownlint: more rules vol. 2#3148
mnocon wants to merge 3 commits into
5.0from
markdownlint-more-rules-even-more

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented Apr 20, 2026 •
edited
Loading

Adding more Markdownlint rules.

It's possible to review the changes commit by commit - each one introduces a new rule.

Some of them are still commented - but I want to keep this PR small to make it easier to review.

Please note d9deae3 - as the image field reference used to embed a file outside of snippets, it broke when the lines moved. I've extracted the code sample to avoid this happening in the future.

Enabled rules:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026 •
edited
Loading

Preview of modified files

Preview of modified Markdown:

@mnocon mnocon force-pushed the markdownlint-more-rules-even-more branch 5 times, most recently from b565655 to 0b456b7 Compare April 20, 2026 13:27
@mnocon mnocon marked this pull request as ready for review April 20, 2026 13:28
@mnocon mnocon requested a review from a team April 20, 2026 13:28
@ibexa-workflow-automation-1 ibexa-workflow-automation-1 Bot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team April 20, 2026 13:28
@mnocon mnocon force-pushed the markdownlint-more-rules branch from 5376968 to bc10f47 Compare May 17, 2026 14:44
@mnocon mnocon force-pushed the markdownlint-more-rules-even-more branch 2 times, most recently from 09be379 to 3497e80 Compare May 17, 2026 14:53
@mnocon mnocon changed the base branch from markdownlint-more-rules to 5.0 May 17, 2026 14:57
@mnocon mnocon force-pushed the markdownlint-more-rules-even-more branch 4 times, most recently from 0570548 to 3e2953b Compare May 17, 2026 15:13
@mnocon mnocon force-pushed the markdownlint-more-rules-even-more branch from 3e2953b to d92481f Compare May 17, 2026 15:16
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 17, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

code_samples/ change report

Before (on target branch)After (in current PR)

code_samples/templates/field_twig_functions/render_content.html.twig


code_samples/templates/field_twig_functions/render_content.html.twig

docs/templating/twig_function_reference/field_twig_functions.md@38:``` html+twig
docs/templating/twig_function_reference/field_twig_functions.md@39:[[= include_code('code_samples/templates/field_twig_functions/render_content.html.twig') =]]
docs/templating/twig_function_reference/field_twig_functions.md@40:```

001⫶{{ ibexa_render_field(content, 'title') }}
002⫶
003⫶{{ ibexa_render_field(content, 'image', {
004⫶    'template': '@ibexadesign/fields/image.html.twig',
005⫶    'attr': {class: 'thumbnail-image'},
006⫶    'parameters': {
007⫶        'alias': 'small'
008⫶    }
009⫶}) }}

docs/templating/twig_function_reference/image_twig_functions.md@15:``` html+twig
docs/templating/twig_function_reference/image_twig_functions.md@16:[[= include_code('code_samples/templates/field_twig_functions/render_content.html.twig', 3, 9, remove_indent=True) =]]
docs/templating/twig_function_reference/image_twig_functions.md@17:```

001⫶{{ ibexa_render_field(content, 'image', {
002⫶    'template': '@ibexadesign/fields/image.html.twig',
003⫶    'attr': {class: 'thumbnail-image'},
004⫶    'parameters': {
005⫶        'alias': 'small'
006⫶    }
007⫶}) }}


code_samples/templates/field_twig_functions/render_product.html.twig


code_samples/templates/field_twig_functions/render_product.html.twig

docs/templating/twig_function_reference/field_twig_functions.md@42:``` html+twig
docs/templating/twig_function_reference/field_twig_functions.md@43:[[= include_code('code_samples/templates/field_twig_functions/render_product.html.twig') =]]
docs/templating/twig_function_reference/field_twig_functions.md@44:```

001⫶{{ ibexa_render_field(product, 'name') }}
002⫶
003⫶{{ ibexa_render_field(product, 'image', {
004⫶    'template': '@ibexadesign/fields/image.html.twig',
005⫶    'attr': {class: 'thumbnail-image'},
006⫶    'parameters': {
007⫶        'alias': 'small'
008⫶    }
009⫶}) }}


Download colorized diff

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    
















  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

          


  
      @adriendupuis
  
    adriendupuis


                Awaiting requested review from adriendupuis


        
      

      

          


  
      @dabrt
  
    dabrt


                Awaiting requested review from dabrt


        
      

      

          


  
      @julitafalcondusza
  
    julitafalcondusza


                Awaiting requested review from julitafalcondusza


        
      


      






    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    Needs DOC review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      1 participant
    

    

        
          @mnocon