CC-60: <Select/> Items Lack Padding#26
Conversation
Fixes CC-60
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughThe Select component was updated to support flexible sizing by adjusting option item styling and wiring the size property into style class name computation. Fixed min-height and explicit height constraints were removed from select items and story examples, replaced with explicit padding. The icon size within select item indicators was reduced from 1.25rem to 1rem. The component logic now passes the size value to getStyleClassNames for option items, enabling size-aware styling. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.11.0)src/components/Select/Select.module.scssConfigurationError: Could not find "stylelint-config-clean-order". Do you need to install the package or use the "configBasedir" option? Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes CC-60
Summary by CodeRabbit