Skip to content

CC-40: <RadioCards/> with Null do not Highlight#25

Merged
ianpaschal merged 1 commit into
masterfrom
ian/cc-40-radiocards-with-null-do-not-highlight
May 13, 2026
Merged

CC-40: <RadioCards/> with Null do not Highlight#25
ianpaschal merged 1 commit into
masterfrom
ian/cc-40-radiocards-with-null-do-not-highlight

Conversation

@ianpaschal
Copy link
Copy Markdown
Owner

@ianpaschal ianpaschal commented May 13, 2026

Fixes CC-40

Summary by CodeRabbit

  • Bug Fixes
    • Improved styling behavior in RadioCards component when handling null option values.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c05d7c6f-b460-4dd6-938b-ab011caf7e4b

📥 Commits

Reviewing files that changed from the base of the PR and between 28bfaa8 and a1aaed5.

📒 Files selected for processing (1)
  • src/components/RadioCards/RadioCards.tsx

Walkthrough

This PR simplifies the RadioCards component's option styling logic. Previously, each radio card's variant and intent styling were computed using a null guard condition (v !== null && v === currentValue). The change removes this guard, replacing it with a direct equality check (v === currentValue). This allows null option values to match and receive selected styling when the current value is also null.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing RadioCards highlighting behavior when null values are involved, which matches the PR's objectives and code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ian/cc-40-radiocards-with-null-do-not-highlight

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ianpaschal ianpaschal merged commit d826f94 into master May 13, 2026
2 checks passed
@ianpaschal ianpaschal deleted the ian/cc-40-radiocards-with-null-do-not-highlight branch May 13, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant