fix!: remove bellecour and SGX Scone support#553
Merged
PierreJeanjacquot merged 11 commits intomainfrom Apr 29, 2026
Merged
Conversation
PierreJeanjacquot
force-pushed
the
fix/remove-bellecour-sgx
branch
2 times, most recently
from
f95199a to
6bf7715
Compare
BREAKING CHANGE: ENS names are no longer accepted as addresses; all address fields now require a plain Ethereum address; drops the AddressOrENS type in favour of Address.
BREAKING CHANGE: Remove useVoucher and voucherOwner params from `processProtectedData` and `processBulkRequest`.
PierreJeanjacquot
changed the title
PierreJeanjacquot
force-pushed
the
fix/remove-bellecour-sgx
branch
2 times, most recently
from
83e57fd to
4156358
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Bellecour defaults and SGX SCONE / ENS / voucher-related support from the SDK, and migrates the test stack + fixtures to Arbitrum Sepolia (chainId 421614).
Changes:
- Drop ENS (
AddressOrENS,addressOrEnsSchema, ENS resolution) and voucher logic from core workflows. - Switch defaults, fixtures, and test stack configuration from Bellecour (134) to Arbitrum Sepolia (421614), including updated TEE tags (
tdx). - Update web3 provider construction and test utilities to match the new network requirements.
Reviewed changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk/tests/utils/workerpoolOrders.ts | Update mocked order chainId to Arbitrum Sepolia. |
| packages/sdk/tests/utils/mockAllForProcessProtectedData.ts | Replace bn.js BN with iexec/utils BN; update mocked network chainId and voucher-related fields. |
| packages/sdk/tests/utils/datasetOrders.ts | Update dataset order fixtures to chainId: 421614. |
| packages/sdk/tests/utils/appOrders.ts | Update app order fixtures to chainId: 421614. |
| packages/sdk/tests/unit/utils/validators.test.ts | Remove unit coverage for addressOrEnsSchema. |
| packages/sdk/tests/unit/utils/getMultiaddrAsString.test.ts | Add explicit Jest globals imports for ESM tests. |
| packages/sdk/tests/unit/utils/formatGrantedAccess.test.ts | Add explicit Jest globals imports for ESM tests. |
| packages/sdk/tests/unit/services/arweave.test.ts | Fix Jest globals import to include expect. |
| packages/sdk/tests/unit/getWeb3Provider.test.ts | Update getWeb3Provider usage to require host / chainId; remove Bellecour-default test. |
| packages/sdk/tests/unit/dataProtectorCore/transferOwnership.test.ts | Align validation error messages with address-only validation. |
| packages/sdk/tests/unit/dataProtectorCore/revokeAllAccess.test.ts | Align validation error messages with address-only validation. |
| packages/sdk/tests/unit/dataProtectorCore/protectData.test.ts | Switch unit tests to chainId 421614 config and provide networkName for explorer URLs. |
| packages/sdk/tests/unit/dataProtectorCore/processProtectedData/processProtectedData.test.ts | Update imports/mocks and validation error messages after voucher/ENS removal. |
| packages/sdk/tests/unit/dataProtectorCore/processBulkRequest.test.ts | Remove voucher-related tests and unused orderbook mocks. |
| packages/sdk/tests/unit/dataProtectorCore/prepareBulkRequest.test.ts | Align validation error messages with address-only validation and remove voucher mock. |
| packages/sdk/tests/unit/dataProtectorCore/grantAccess.test.ts | Remove ENS resolution test and SCONE-specific appMREnclave mocking; align validation messages. |
| packages/sdk/tests/unit/dataProtectorCore/getProtectedData.test.ts | Remove ENS-related validations and redundant iexec param usage; improve typing for spies. |
| packages/sdk/tests/unit/dataProtectorCore/getGrantedAccess.test.ts | Align validation error messages and mocked chainId to 421614. |
| packages/sdk/tests/unit/constructor.test.ts | Update constructor tests for new provider host requirements and chain config defaults; adjust expected error text. |
| packages/sdk/tests/test-utils.ts | Migrate test utilities to Arbitrum Sepolia; make getTestConfig/signer provider async and prefund accounts via anvil_setBalance; remove SCONE/mrenclave plumbing. |
| packages/sdk/tests/prepare-test-env.js | Generate .env for Arbitrum Sepolia fork/indexing with top-level await and new env var names. |
| packages/sdk/tests/prepare-iexec.js | Remove node_modules patching script for checkImplementedOnChain. |
| packages/sdk/tests/e2e/dataProtectorCore/waitForTaskCompletion.test.ts | Update e2e fixtures and async config initialization for new test config API. |
| packages/sdk/tests/e2e/dataProtectorCore/transferOwnership.test.ts | Update e2e config initialization for async getTestConfig. |
| packages/sdk/tests/e2e/dataProtectorCore/revokeOneAccess.test.ts | Rename SCONE variables to generic TEE naming and update async config usage. |
| packages/sdk/tests/e2e/dataProtectorCore/revokeAllAccess.test.ts | Update async config initialization and rename SCONE variables to TEE naming. |
| packages/sdk/tests/e2e/dataProtectorCore/protectData.test.ts | Update async signer/config handling and adapt to new test utilities. |
| packages/sdk/tests/e2e/dataProtectorCore/processProtectedData.test.ts | Switch order tags from scone to tdx and update async config acquisition. |
| packages/sdk/tests/e2e/dataProtectorCore/inspectBulkRequest.test.ts | Switch order tags from scone to tdx and update async config acquisition. |
| packages/sdk/tests/e2e/dataProtectorCore/grantAccess.test.ts | Update async config handling, remove SCONE-specific expectations, and update whitelist contract address. |
| packages/sdk/tests/e2e/dataProtectorCore/getProtectedData.test.ts | Remove ENS-based e2e cases and update async config acquisition. |
| packages/sdk/tests/e2e/dataProtectorCore/getGrantedAccess.test.ts | Switch tags from scone to tdx, update async config usage, and improve typing. |
| packages/sdk/tests/e2e/constructor.test.ts | Remove e2e constructor test relying on signer-less defaults. |
| packages/sdk/tests/docker-compose.yml | Replace Bellecour fork stack with Arbitrum Sepolia fork stack; update watcher/API/graphnode configuration and start blocks. |
| packages/sdk/src/utils/validators.ts | Remove ENS detection and addressOrEnsSchema; keep address-only schema. |
| packages/sdk/src/utils/resolveENS.ts | Remove ENS resolution helper. |
| packages/sdk/src/utils/processProtectedData.models.ts | Remove voucher-based filtering logic from workerpool order selection. |
| packages/sdk/src/utils/getWeb3Provider.ts | Change provider helper to require explicit host / chainId. |
| packages/sdk/src/utils/getChainId.ts | Remove fallback chainId behavior; always detect via IExecNetworkModule. |
| packages/sdk/src/lib/types/internalTypes.ts | Remove voucher types; introduce NetworkNameConsumer; change contract address consumer to Address. |
| packages/sdk/src/lib/types/graphQLTypes.ts | Remove AddressOrENS from subgraph types. |
| packages/sdk/src/lib/types/coreTypes.ts | Remove ENS/voucher-related params across public types; make address fields strictly Address. |
| packages/sdk/src/lib/types/commonTypes.ts | Remove AddressOrENS and voucher match options; tighten config types to address-only. |
| packages/sdk/src/lib/dataProtectorCore/transferOwnership.ts | Switch validation from address-or-ENS to address-only. |
| packages/sdk/src/lib/dataProtectorCore/smartContract/getWhitelistContract.ts | Tighten contract address type to Address (no ENS). |
| packages/sdk/src/lib/dataProtectorCore/smartContract/getDataProtectorCoreContract.ts | Tighten contract address type to Address (no ENS). |
| packages/sdk/src/lib/dataProtectorCore/revokeAllAccess.ts | Switch validation from address-or-ENS to address-only. |
| packages/sdk/src/lib/dataProtectorCore/protectData.ts | Add networkName for explorer URL generation; remove txOptions usage in contract call. |
| packages/sdk/src/lib/dataProtectorCore/processProtectedData.ts | Remove voucher logic and ENS validation; adjust requester strictness and defaults. |
| packages/sdk/src/lib/dataProtectorCore/processBulkRequest.ts | Remove voucher logic from matching/estimation and tighten validation to address-only. |
| packages/sdk/src/lib/dataProtectorCore/prepareBulkRequest.ts | Switch validation to address-only. |
| packages/sdk/src/lib/dataProtectorCore/grantAccess.ts | Remove ENS resolution logic and tighten validations to address-only. |
| packages/sdk/src/lib/dataProtectorCore/getProtectedData.ts | Remove ENS resolution and dependency on iexec for read queries. |
| packages/sdk/src/lib/dataProtectorCore/getGrantedAccess.ts | Switch validation to address-only. |
| packages/sdk/src/lib/dataProtectorCore/IExecDataProtectorCore.ts | Pass networkName into protectData; stop passing iexec into getProtectedData. |
| packages/sdk/src/lib/IExecDataProtectorModule.ts | Require explicit ethProvider and compute/store networkName from chain config. |
| packages/sdk/src/config/config.ts | Remove Bellecour config and default chain; normalize Arbitrum Sepolia contract address casing. |
| packages/sdk/package.json | Remove test:prepare hook and stop running node_modules patching as part of starting the test stack. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
BREAKING CHANGE: `host` is now required as second positional argument of `getWeb3Provider` instead of being nested inside the options object. Removes the implicit bellecour default.
BREAKING CHANGE: ethProvider is required in the IExecDataProtectorModule constructor
BREAKING CHANGE: bellecour chain is no longer supported
PierreJeanjacquot
force-pushed
the
fix/remove-bellecour-sgx
branch
2 times, most recently
from
5555201 to
726918c
Compare
PierreJeanjacquot
force-pushed
the
fix/remove-bellecour-sgx
branch
from
726918c to
e8d2b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.