Skip to content

Fix leaderboard display issues and refresh behavior #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hexwarrior6 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix leaderboard display issues and refresh behavior #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c5af00
fix: fix leaderboards refresh blank page
hexwarrior6 Apr 26, 2026
4f4b014
fix: fix leaderboard panel height alignment
hexwarrior6 Apr 26, 2026
52eb1ce
fix: keep leaderboard chart row height stable when toggling compact/e…
hexwarrior6 Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions src/components/charts/bar-leaderboard-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,14 +189,6 @@ export function BarLeaderboardChart<T extends BarLeaderboardDatumBase>({
el.scrollBy({ left: delta, behavior: 'smooth' });
}, []);

if (!data.length) {
return (
<div className="flex h-[200px] items-center justify-center text-sm text-muted-foreground sm:h-[240px]">
暂无数据
</div>
);
}

const axisKey = mode === 'provider' ? 'provider' : 'normalizedModelDisplay';
const metricAxis =
metric === 'ttft'
Expand All @@ -209,7 +201,8 @@ export function BarLeaderboardChart<T extends BarLeaderboardDatumBase>({
}
: getMetricAxisProps('tps');

const showLabelText = effectiveMode === 'scroll' || data.length <= (isMobile ? 6 : 12);
const showLabelText = data.length <= (isMobile ? 6 : 12);
const xAxisHeight = showLabelText ? (isMobile ? 40 : 52) : (isMobile ? 24 : 30);
const hasOverflow = effectiveMode === 'scroll' && innerWidth > wrapperWidth;
const showLeftFade = hasOverflow && scrollState.left > 4;
const showRightFade = hasOverflow && scrollState.left < scrollState.max - 4;
Expand All @@ -228,8 +221,8 @@ export function BarLeaderboardChart<T extends BarLeaderboardDatumBase>({
interval={effectiveMode === 'scroll' ? 0 : isMobile ? 'preserveStartEnd' : 0}
tickLine={false}
axisLine={false}
tick={<BarXAxisTick mode={mode} data={data} isMobile={isMobile} showText={showLabelText} />}
height={isMobile ? 40 : 52}
tick={<BarXAxisTick mode={mode} data={data} isMobile={isMobile} showText={showLabelText} axisHeight={xAxisHeight} />}
height={xAxisHeight}
/>
<YAxis
{...metricAxis}
Expand All @@ -249,6 +242,14 @@ export function BarLeaderboardChart<T extends BarLeaderboardDatumBase>({
[data, dataKey, axisKey, mode, metric, tooltipContent, isMobile, effectiveMode, innerWidth, effectiveHeight, showLabelText, metricAxis],
);

if (!data.length) {
return (
<div className="flex h-[200px] items-center justify-center text-sm text-muted-foreground sm:h-[240px]">
暂无数据
</div>
);
}

return (
<div ref={wrapperRef} className="relative w-full">
<ChartModeToggle
Expand Down Expand Up @@ -309,7 +310,7 @@ export function BarLeaderboardChart<T extends BarLeaderboardDatumBase>({
) : null}

{effectiveMode === 'scroll' ? (
<div className="mt-1 text-right text-[10px] text-muted-foreground/80">
<div className="pointer-events-none absolute bottom-0 right-0 bg-background/70 px-1 text-right text-[10px] text-muted-foreground/80 backdrop-blur-sm">
可横向拖动 / 滚轮 / 滑动浏览全部 {data.length} 项
</div>
) : null}
Expand Down Expand Up @@ -349,9 +350,10 @@ interface BarXAxisTickProps {
data: BarLeaderboardDatumBase[];
isMobile: boolean;
showText: boolean;
axisHeight: number;
}

function BarXAxisTick({ x = 0, y = 0, payload, mode, data, isMobile, showText }: BarXAxisTickProps) {
function BarXAxisTick({ x = 0, y = 0, payload, mode, data, isMobile, showText, axisHeight }: BarXAxisTickProps) {
if (!payload) return null;
const value = String(payload.value ?? '');
const record = data.find((d) => {
Expand All @@ -363,13 +365,16 @@ function BarXAxisTick({ x = 0, y = 0, payload, mode, data, isMobile, showText }:
const maxLen = isMobile ? 6 : 10;
const label = value.length > maxLen ? `${value.slice(0, maxLen)}…` : value;
const glyphSize = isMobile ? 14 : 18;
const glyphContainerHeight = glyphSize + 4;
const glyphY = showText ? 2 : Math.max(0, (axisHeight - glyphContainerHeight) / 2);
const textY = isMobile ? 26 : 34;
return (
<g transform={`translate(${x}, ${y + 2})`}>
<foreignObject
x={-(glyphSize + 6)}
y={2}
y={glyphY}
width={(glyphSize + 6) * 2}
height={glyphSize + 4}
height={glyphContainerHeight}
style={{ overflow: 'visible' }}
>
<div className="flex items-center justify-center">
Expand All @@ -383,7 +388,7 @@ function BarXAxisTick({ x = 0, y = 0, payload, mode, data, isMobile, showText }:
{showText ? (
<text
x={0}
y={isMobile ? 26 : 34}
y={textY}
textAnchor="middle"
fill="hsl(var(--muted-foreground))"
fontSize={isMobile ? 9 : 10}
Expand Down
Loading