ci: publish via pnpm when selected#28
Open
gndelia wants to merge 1 commit into
Open
Conversation
Branch the npm-publish workflow's prepublishOnly and publish steps on inputs.package-manager so pnpm callers actually run pnpm publish instead of npm publish. Dispatch via step-level `if:` rather than interpolating the input value into the run: script, which would be a GitHub Actions script-injection vector if a caller passed an unexpected string.
4 tasks
joshuasing
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch the
npm-publishreusable workflow'sprepublishOnlyandpublishsteps oninputs.package-manager, so callers that opt into pnpm actually invokepnpm publishinstead ofnpm publish.This is needed to unlock pnpm-specific publish behavior. Concretely, for a
publishConfiglike:npm publishonly honors the npm config keys (access,provenance) and ignores thepackage.jsonfield overrides (main,types,exports) — it ships the raw top-level fields, which would point at source paths and break consumers.pnpm publishreads those overrides and rewrites the publishedpackage.jsonaccordingly. I need this for publishing the vetro packages.Dispatch is implemented via step-level
if:guards (one fornpm, one forpnpm) rather than interpolating${{ inputs.package-manager }}intorun:, to avoid a GitHub Actions script-injection vector if a caller ever passed an unexpected value.Related to vetro-protocol/vetro-monorepo#423.