Fix internal error sliding through a compute_with-fused loop#9149
Merged
Conversation
AddLoopMinOrig referred to a Variable("<loop>.loop_min") for the value of
its .loop_min.orig let. For loops renamed by compute_with's
substitute_fused_bounds, no .loop_min let exists under the fused name,
so sliding window emitted references to a non-existent symbol and
codegen failed with "Symbol not found: ...fused...loop_min". Use the
loop's min expression directly instead.
Also fix a pre-existing oversight in apps/harris/Makefile where
\$(GENERATOR_OUTPUTS) was not passed to the generator.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
alexreinking
approved these changes
May 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9149 +/- ##
=======================================
Coverage ? 69.29%
=======================================
Files ? 254
Lines ? 78219
Branches ? 18714
=======================================
Hits ? 54204
Misses ? 18503
Partials ? 5512 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While messing with alternative harris schedules, I encountered an internal compiler error about a missing symbol. Claude says:
AddLoopMinOrig referred to a Variable(".loop_min") for the value of its .loop_min.orig let. For loops renamed by compute_with's substitute_fused_bounds, no .loop_min let exists under the fused name, so sliding window emitted references to a non-existent symbol and codegen failed with "Symbol not found: ...fused...loop_min". Use the loop's min expression directly instead.
Also fix a pre-existing oversight in apps/harris/Makefile where $(GENERATOR_OUTPUTS) was not passed to the generator.