Use vertical rules grid API for galleries#15776
Open
frederickobrien wants to merge 2 commits intomainfrom
Open
Use vertical rules grid API for galleries#15776frederickobrien wants to merge 2 commits intomainfrom
grid API for galleries#15776frederickobrien wants to merge 2 commits intomainfrom
Conversation
frederickobrien
added
the
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #15760, this uses the newly available
verticalRulesoption in thegridmodule to apply outer lines to the gallery layout grid containers. Seems to work fine!The centre line in
GalleryCaption.tsxis trickier here than in more conventional article layouts as it moves around a fair bit depending on breakpoint. TheverticalRules({ centre: true })doesn't do the trick as is so I've left it alone.May be surplus to requirements but I've also adjusted the CSS so that the left border of Gallery headers aligns with the body:
May not be the desired look but thought it was worth including just in case!