Specify legacy config fields from frontend in the config types

[cemms1]

What does this change?

• Adds LegacyConfig type to document the config fields being sent to DCR in the POST request from frontend

  • For articles, these are marked as optional, as well as all nested object keys, to ensure nothing is accidentally broken in schema validation as part of this change

• Adds FELegacyConfig to split the FEFrontConfig into the items more likely to be useful and those which are likely not to be used

  • Adds note in comment for the legacy config that this could be a starting point to begin removing items from frontend that are not needed

• Updates the hostedArticle and hostedVideo fixtures, which now have all the properties in them as they appear in the DCR JSON response. The previous version of these files had the additional config files manually stripped out due to conflicting config

• Updates the schema definitions based on this config definition

Why?

Frontend sends a huge amount of data to DCR in the requests. Because our type config is not up to date, when creating a new fixture based on the DCR JSON response for an article page (suffix .json?dcr) there are errors due to certain fields not being recognised on the Config type

e.g. tones in the following screenshot:

Reimplements part of PR #15531

[github-actions]

Deploy build 26539 of dotcom:rendering-all to CODE

All deployment options

• Deploy build 26539 of dotcom:rendering-all to CODE
• Deploy parts of build 26539 to CODE by previewing it first
• What's on CODE right now?

---

From guardian/actions-riff-raff.

[github-actions]

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

[arelra]

I wonder if we should add a TODO to FEFrontConfig to remove any redundant config matched in this object. It just seems to be a flat list with no 'legacy' distinction.

dotcom-rendering/dotcom-rendering/src/frontend/feFront.ts

Line 317 in bf2b503

export type FEFrontConfig = {

[cemms1]

Have split the FEFrontConfig into the standard config and the parts I believe to be legacy config, with a similar comment about removing from the frontend DCR model

[arelra]

Great work 👏
This puts us in a good position to start deleting redundant config.

Thanks for the spot and fix