fix: load marker images from path, not from the assets#575
Open
kota113 wants to merge 1 commit intogooglemaps:mainfrom
Open
fix: load marker images from path, not from the assets#575kota113 wants to merge 1 commit intogooglemaps:mainfrom
kota113 wants to merge 1 commit intogooglemaps:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes how marker pin images passed from React Native are loaded in MapView.
Motivation
The current implementation uses a method for loading files from the app's asset directory, which is not appropriate for loading images from the React Native JavaScript runtime.
Test
Tests are not added since it's a small bug fix, but I confirmed it works.
Pre-launch Checklist