fix: guard against null in StreetView panorama change listeners#904
Open
balazsbarany wants to merge 1 commit intogooglemaps:mainfrom
Open
fix: guard against null in StreetView panorama change listeners#904balazsbarany wants to merge 1 commit intogooglemaps:mainfrom
balazsbarany wants to merge 1 commit intogooglemaps:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fe2602c to
81a3328
Compare
The OnStreetViewPanoramaChangeListener and OnStreetViewPanoramaCameraChangeListener Java interfaces do not annotate their parameters as @nonnull. The GMS dynamite module (policy_maps_core_dynamite) can deliver null to these listeners on certain devices and Play Services versions. The Kotlin compiler inserts an implicit null-check intrinsic at lambda entry which throws a NullPointerException before the assignment is reached, crashing the app. Fixes the crash by guarding both assignments with a null-safe let block.
81a3328 to
89b4b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
OnStreetViewPanoramaChangeListenerandOnStreetViewPanoramaCameraChangeListenerJava interfaces inplay-services-mapsdo not annotate their callback parameters as@NonNull. The GMS dynamite module (policy_maps_core_dynamite) can delivernullto these listeners on certain devices and Play Services versions.In
StreetViewPanoramaPropertiesNode.onAttached(), both lambdas assigned the callback value directly to non-nullable Kotlin state fields (rawLocationandrawPanoramaCamera). The Kotlin compiler inserts an implicit null-check intrinsic at lambda entry — before the assignment — which throws aNullPointerExceptionwhennullarrives, crashing the app.Crash trace
Lambda index 3 in
onAttached()is thesetOnStreetViewPanoramaChangeListenercallback. ThegetClass()call is the Kotlin-generated null check, not application code.Changes
Guard both listener assignments with a null-safe
letblock inStreetViewPanoramaUpdater.kt:The same pattern is applied to
setOnStreetViewPanoramaCameraChangeListenerfor consistency, asStreetViewPanoramaCamerais also non-nullable inrawPanoramaCamerabut the Java interface carries no@NonNullguarantee.Testing
The fix is purely defensive against a null delivery from the GMS layer, which cannot be injected in an instrumented test. The existing
StreetViewTestscontinue to exercise the normal flow unchanged.