Correctly generate methods when overriding an interface with a default impl.#2754
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_917627069
branch
4 times, most recently
from
93c4723 to
6b2e0a2
Compare
…t impl. --- When compiling for j2objc using ObjectiveCKmpMethod adapters, if a concrete implemention overrides a default method of an interface, we should generate the adapter method, otherwise it fails to compile. PiperOrigin-RevId: 918284502
copybara-service
Bot
force-pushed
the
test_917627069
branch
from
6b2e0a2 to
4cbb05a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly generate methods when overriding an interface with a default impl.
When compiling for j2objc using ObjectiveCKmpMethod adapters, if a concrete implemention overrides a default method of an interface, we should generate the adapter method, otherwise it fails to compile.