Migrate to using shared libraries.#2582
Open
3405691582 wants to merge 1 commit into
Open
Conversation
3405691582
force-pushed
the
509968291_3
branch
2 times, most recently
from
73a55e5 to
aede690
Compare
In google#2573 we set up some new targets to build shared libraries. This commit migrates all binary targets with dependencies on //cuttlefish/result, //libbase, //cuttlefish/common/libs/fs:fs, and //cuttlefish/common/utils:files to use the shared library targets instead. This results in the generated deb decreasing from 110M to 103M and the reported Installed-Size decreasing from 450179K to 414364K, a reduction of 35M. Actual on-disk build size has reduced from 2.4G to 2.2G. More aggressive reductions could likely be achieved by migrating other common libraries to shared libraries. While we are here: we also ensure //cuttlefish/result has a dependency on fmt, to ensure that inline usages (like in casimir_control_server) correctly depend on fmt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2573 we set up some new targets to build shared libraries. This commit migrates all binary targets with dependencies on //cuttlefish/result, //libbase, //cuttlefish/common/libs/fs:fs, and //cuttlefish/common/utils:files to use the shared library targets instead.
This results in the generated deb decreasing from 110M to 103M and the reported Installed-Size decreasing from 450179K to 414364K, a reduction of 35M. Actual on-disk build size has reduced from 2.4G to 2.2G. More aggressive reductions could likely be achieved by migrating other common libraries to shared libraries.
While we are here: we also ensure //cuttlefish/result has a dependency on fmt, to ensure that inline usages (like in casimir_control_server) correctly depend on fmt.