Remove acl-restore.sh, and add user to kvm group instead#2580
Draft
0405ysj wants to merge 1 commit into
Draft
Conversation
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
0405ysj
force-pushed
the
setfacl
branch
5 times, most recently
from
10cb279 to
593edcf
Compare
jemoreira
reviewed
May 19, 2026
| for unique_group in "${unique_groups[@]}"; do | ||
| sudo usermod -aG "$unique_group" "$username" | ||
| done | ||
| echo "Warning: Please reboot the machine (or log out and log back in) before using podcvd." |
Member
There was a problem hiding this comment.
The whole point of having the restore acls service is that logging out and back in is not necessary. Also, the groups for the device nodes can change, in fact cuttlefish-base changes them, so depending on those can be risky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: b/514558958