fix(cli): restore Dev UI graph and fix FunctionTool complex type crash#5447
Open
EaCognitive wants to merge 6 commits intogoogle:mainfrom
Open
fix(cli): restore Dev UI graph and fix FunctionTool complex type crash#5447EaCognitive wants to merge 6 commits intogoogle:mainfrom
EaCognitive wants to merge 6 commits intogoogle:mainfrom
Conversation
…rash - Re-adds missing /dev/build_graph_image/ endpoint to fix broken dev UI graph visualization (google#5430). - Strips unsupported prefixItems/unevaluatedItems from JSON schema to fix FunctionTool crash on complex types (google#5428). - Fixes circular import NameError by moving common decorators to the top of cli_tools_click.py. - Resolves TypeErrors in cli_run and tests by correctly propagating new options (max_llm_calls, avatar_config, trigger_sources). - Updates test_adk_run to correctly ignore the handled 'verbose' option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two high-priority issues and several structural bugs in the ADK CLI and Web Server.
Bug Fixes
/dev/build_graph_image/endpoint. The frontend was requesting this endpoint for SVG rendering, but the backend was only serving JSON/DOT.list[tuple[bytes, str]]parameter type #5428): Implemented a recursive cleaner to stripprefixItemsandunevaluatedItemsfrom Pydantic-generated schemas. These keys are currently unsupported by the Gemini API and causedExtra inputs are not permittedvalidation errors.Structural Improvements
fast_api_common_optionsand other decorators to the top ofcli_tools_click.pyto fix a circular dependency/initialization order issue.cli_runand internal test mocks to correctly accept and propagate new parameters (max_llm_calls,avatar_config,trigger_sources).verboseoption mismatch intest_adk_runto align with the decorator's internal handling.Verification
FunctionToolno longer crashes withlist[tuple[bytes, str]].pytest tests/unittests/cli); all 87 tests passed (after installingrouge-scorein the local environment).