Security: Use pip install with hash verification for yamllint#6327
Open
jencarlucci wants to merge 1 commit intomainfrom
Open
Security: Use pip install with hash verification for yamllint#6327jencarlucci wants to merge 1 commit intomainfrom
jencarlucci wants to merge 1 commit intomainfrom
Conversation
Add requirements.txt with pinned hashes for yamllint and its dependencies. Update the linter workflow to use --require-hashes to ensure integrity of installed packages. Closes github/vuln-mgmt#195710
Contributor
There was a problem hiding this comment.
Pull request overview
This PR remediates a security finding in the GitHub Actions linter workflow by switching pip install to hash-verified installs for yamllint, ensuring dependencies are pinned and integrity-checked.
Changes:
- Add a
requirements.txtgenerated withpip-compile --generate-hashescontaining pinnedyamllintand dependencies with hashes. - Update
.github/workflows/linter.ymlto install fromrequirements.txtusingpip install --require-hashes.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Introduces pinned, hash-verified Python dependencies for the linter workflow. |
| .github/workflows/linter.yml | Switches yamllint installation to --require-hashes + -r requirements.txt. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Finding Remediation
--require-hashesCloses https://github.com/github/vuln-mgmt/issues/195710