This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Use npm ci instead of npm install in linting workflow#93
Merged
Conversation
Agent-Logs-Url: https://github.com/github/github-app-js-sample/sessions/835c72cb-c5ec-4dd4-b6b6-6bf99cac988c Co-authored-by: tarebyte <564113+tarebyte@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning alert(s) flagged in this repository
Use Apr 23, 2026
npm ci instead of npm install in linting workflow
There was a problem hiding this comment.
Pull request overview
Updates the linting GitHub Actions workflow to use deterministic dependency installation, reducing the risk of CI drift from fetching unintended dependency updates.
Changes:
- Replaces
npm install standardwithnpm ciin the linting workflow. - Relies on the existing
package-lock.jsonanddevDependencies(includingstandard) to ensure reproducible installs.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/linting.yml |
Switches lint job dependency installation to npm ci for lockfile-driven, deterministic installs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
tarebyte
approved these changes
Apr 23, 2026
lrotschy
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm install standardin the linting workflow is non-deterministic — it can fetch updated versions and mutatepackage-lock.json, leading to inconsistent CI builds (CWE-829).Changes
.github/workflows/linting.yml: Replacenpm install standardwithnpm cistandardis already adevDependencyinpackage.json, sonpm ciinstalls it (and all deps) from the lockfile — no separate install step needednpm cienforces lockfile consistency and fails fast ifpackage-lock.jsonis out of sync withpackage.json