Skip to content

Add Hibernate SQL injection sink models and coverage #21749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+84 −1
Open

Add Hibernate SQL injection sink models and coverage #21749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b897ad
Initial plan
Copilot Apr 23, 2026
081ad03
Add Hibernate SQL injection sink tests
Copilot Apr 23, 2026
25d232b
Model additional Hibernate query sinks
Copilot Apr 23, 2026
083909e
Add Java change note for Hibernate sinks
Copilot Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions java/ql/lib/change-notes/2026-04-23-hibernate-queryproducer-sinks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Added `sql-injection` sink models for the Hibernate `org.hibernate.query.QueryProducer` methods `createNativeMutationQuery`, `createMutationQuery`, and `createSelectionQuery`.
3 changes: 3 additions & 0 deletions java/ql/lib/ext/org.hibernate.query.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,8 @@ extensions:
extensible: sinkModel
data:
- ["org.hibernate.query", "QueryProducer", True, "createNativeQuery", "", "", "Argument[0]", "sql-injection", "manual"]
- ["org.hibernate.query", "QueryProducer", True, "createNativeMutationQuery", "", "", "Argument[0]", "sql-injection", "manual"]
- ["org.hibernate.query", "QueryProducer", True, "createQuery", "", "", "Argument[0]", "sql-injection", "manual"]
- ["org.hibernate.query", "QueryProducer", True, "createMutationQuery", "", "", "Argument[0]", "sql-injection", "manual"]
- ["org.hibernate.query", "QueryProducer", True, "createSelectionQuery", "", "", "Argument[0]", "sql-injection", "manual"]
- ["org.hibernate.query", "QueryProducer", True, "createSQLQuery", "", "", "Argument[0]", "sql-injection", "manual"]
25 changes: 25 additions & 0 deletions java/ql/test/query-tests/security/CWE-089/semmle/examples/Hibernate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import org.hibernate.Session;
import org.hibernate.SharedSessionContract;
import org.hibernate.query.QueryProducer;

public class Hibernate {

public static String source() { return null; }

public static void test(
Session session, SharedSessionContract sharedSessionContract, QueryProducer queryProducer) {
session.createQuery(source()); // $ sqlInjection
session.createSQLQuery(source()); // $ sqlInjection

sharedSessionContract.createQuery(source()); // $ sqlInjection
sharedSessionContract.createSQLQuery(source()); // $ sqlInjection

queryProducer.createNativeQuery(source()); // $ sqlInjection
queryProducer.createNativeMutationQuery(source()); // $ sqlInjection
queryProducer.createQuery(source()); // $ sqlInjection
queryProducer.createMutationQuery(source()); // $ sqlInjection
queryProducer.createSelectionQuery(source()); // $ sqlInjection
queryProducer.createSelectionQuery(source(), Object.class); // $ sqlInjection
queryProducer.createSQLQuery(source()); // $ sqlInjection
}
}
2 changes: 1 addition & 1 deletion java/ql/test/query-tests/security/CWE-089/semmle/examples/options
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
//semmle-extractor-options: --javac-args -cp ${testdir}/../../../../../stubs/mongodbClient:${testdir}/../../../../../stubs/couchbaseClient:${testdir}/../../../../../stubs/springframework-5.8.x:${testdir}/../../../../../stubs/apache-hive:${testdir}/../../../../../stubs/jakarta-persistence-api-3.2.0 --release 21
//semmle-extractor-options: --javac-args -cp ${testdir}/../../../../../stubs/mongodbClient:${testdir}/../../../../../stubs/couchbaseClient:${testdir}/../../../../../stubs/springframework-5.8.x:${testdir}/../../../../../stubs/apache-hive:${testdir}/../../../../../stubs/jakarta-persistence-api-3.2.0:${testdir}/../../../../../stubs/hibernate-5.x --release 21
10 changes: 10 additions & 0 deletions java/ql/test/stubs/hibernate-5.x/org/hibernate/Session.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions java/ql/test/stubs/hibernate-5.x/org/hibernate/SharedSessionContract.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions java/ql/test/stubs/hibernate-5.x/org/hibernate/query/MutationQuery.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions java/ql/test/stubs/hibernate-5.x/org/hibernate/query/Query.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions java/ql/test/stubs/hibernate-5.x/org/hibernate/query/QueryProducer.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions java/ql/test/stubs/hibernate-5.x/org/hibernate/query/SelectionQuery.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading