Simplify writeDiffRangeDataExtensionPack interface#3849
Open
henrymercer wants to merge 1 commit intomainfrom
Open
Simplify writeDiffRangeDataExtensionPack interface#3849henrymercer wants to merge 1 commit intomainfrom
writeDiffRangeDataExtensionPack interface#3849henrymercer wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the internal writeDiffRangeDataExtensionPack contract so it always returns an extension pack directory when invoked, and it removes now-unreachable fallback logging in the diff-informed analysis setup path. This aligns setupDiffInformedQueryRun with the fact that it already gates execution on successfully reading precomputed diff ranges.
Changes:
- Remove the
undefinedreturn path fromwriteDiffRangeDataExtensionPackby requiring a concreteDiffThunkRange[]input. - Simplify
setupDiffInformedQueryRunlogging by removing the conditional warning/info branch and always logging successful pack creation once reached.
Show a summary per file
| File | Description |
|---|---|
| src/analyze.ts | Makes extension-pack creation always return a path once diff ranges are present; removes unreachable warning path and updates JSDoc/types accordingly. |
| lib/analyze-action.js | Generated build output reflecting the TypeScript changes (not reviewed). |
Copilot's findings
- Files reviewed: 1/2 changed files
- Comments generated: 0
mbg
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/github/codeql-action/security/code-scanning/1203