Skip to content

fix(integrations): Remove asyncio iscoroutinefunction warning #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cooperoptigrid wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix(integrations): Remove asyncio iscoroutinefunction warning #6090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0585e5
change asyncio to inspect for iscoroutinefunction
cooperoptigrid Apr 16, 2026
e8f494d
extract iscoroutinefunction into common
cooperoptigrid Apr 17, 2026
6da51e6
move _markcoroutinefunction back to django asgi
cooperoptigrid Apr 20, 2026
1e6b296
Merge branch 'master' into fix-integration-asyncio-iscoroutine-functi…
cooperoptigrid Apr 20, 2026
70d75ec
Merge branch 'master' into fix-integration-asyncio-iscoroutine-functi…
cooperoptigrid Apr 22, 2026
54f7705
Merge branch 'master' into fix-integration-asyncio-iscoroutine-functi…
cooperoptigrid Apr 23, 2026
60ca522
use PY313 identifier
cooperoptigrid Apr 23, 2026
80e8651
Merge branch 'master' into fix-integration-asyncio-iscoroutine-functi…
cooperoptigrid Apr 23, 2026
3aca594
Merge branch 'master' into fix-integration-asyncio-iscoroutine-functi…
cooperoptigrid Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry_sdk/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
PY38 = sys.version_info[0] == 3 and sys.version_info[1] >= 8
PY310 = sys.version_info[0] == 3 and sys.version_info[1] >= 10
PY311 = sys.version_info[0] == 3 and sys.version_info[1] >= 11
PY313 = sys.version_info[0] == 3 and sys.version_info[1] >= 13


def with_metaclass(meta: "Any", *bases: "Any") -> "Any":
Expand Down
7 changes: 7 additions & 0 deletions sentry_sdk/integrations/_asgi_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import asyncio
import inspect
import urllib

from sentry_sdk._compat import PY313
from sentry_sdk.scope import should_send_default_pii
from sentry_sdk.integrations._wsgi_common import _filter_headers

Expand All @@ -14,6 +17,10 @@

from sentry_sdk.utils import AnnotatedValue

_iscoroutinefunction = (
inspect.iscoroutinefunction if PY313 else asyncio.iscoroutinefunction
)
Comment on lines +20 to +22
Copy link
Copy Markdown

@sentry sentry Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version check for asyncio.iscoroutinefunction deprecation is incorrect. It checks for Python 3.13+ (PY313) but the deprecation occurred in Python 3.12.
Severity: LOW

Suggested Fix

Update the version check to target Python 3.12 instead of 3.13. This can be done by creating and using a PY312 constant or by reverting to the previous check hasattr(inspect, "markcoroutinefunction") which correctly identifies Python 3.12 and newer.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: sentry_sdk/integrations/_asgi_common.py#L20-L22

Potential issue: The code uses a version check for Python 3.13 (`PY313`) to decide
whether to use `inspect.iscoroutinefunction` instead of the deprecated
`asyncio.iscoroutinefunction`. However, `asyncio.iscoroutinefunction` was deprecated
starting in Python 3.12. Consequently, when running on Python 3.12, the code will still
use the deprecated function, generating a `DeprecationWarning`. This negates the
intended fix of the pull request, which was to remove this warning for supported Python
versions.

Also affects:

  • sentry_sdk/_compat.py:16~16

Did we get this right? 👍 / 👎 to inform future reviews.



def _get_headers(asgi_scope: "Any") -> "Dict[str, str]":
"""
Expand Down
6 changes: 3 additions & 3 deletions sentry_sdk/integrations/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"""

import sys
import asyncio
import inspect
from copy import deepcopy
from functools import partial
Expand All @@ -18,6 +17,7 @@
_get_request_attributes,
_get_request_data,
_get_url,
_iscoroutinefunction,
)
from sentry_sdk.integrations._wsgi_common import (
DEFAULT_HTTP_METHODS_TO_CAPTURE,
Expand Down Expand Up @@ -87,10 +87,10 @@ def _looks_like_asgi3(app: "Any") -> bool:
if inspect.isclass(app):
return hasattr(app, "__await__")
elif inspect.isfunction(app):
return asyncio.iscoroutinefunction(app)
return _iscoroutinefunction(app)
else:
call = getattr(app, "__call__", None) # noqa
return asyncio.iscoroutinefunction(call)
return _iscoroutinefunction(call)


class SentryAsgiMiddleware:
Expand Down
7 changes: 3 additions & 4 deletions sentry_sdk/integrations/django/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from sentry_sdk.consts import OP

from sentry_sdk.integrations.asgi import SentryAsgiMiddleware
from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
from sentry_sdk.scope import should_send_default_pii
from sentry_sdk.utils import (
capture_internal_exceptions,
Expand All @@ -41,10 +42,8 @@
# Until 3.12 is the minimum supported Python version, provide a shim.
# This was copied from https://github.com/django/asgiref/blob/main/asgiref/sync.py
if hasattr(inspect, "markcoroutinefunction"):
iscoroutinefunction = inspect.iscoroutinefunction
markcoroutinefunction = inspect.markcoroutinefunction
else:
iscoroutinefunction = asyncio.iscoroutinefunction # type: ignore[assignment]

def markcoroutinefunction(func: "_F") -> "_F":
func._is_coroutine = asyncio.coroutines._is_coroutine # type: ignore
Expand Down Expand Up @@ -215,15 +214,15 @@ def _async_check(self) -> None:
a thread is not consumed during a whole request.
Taken from django.utils.deprecation::MiddlewareMixin._async_check
"""
if iscoroutinefunction(self.get_response):
if _iscoroutinefunction(self.get_response):
markcoroutinefunction(self)

def async_route_check(self) -> bool:
"""
Function that checks if we are in async mode,
and if we are forwards the handling of requests to __acall__
"""
return iscoroutinefunction(self.get_response)
return _iscoroutinefunction(self.get_response)

async def __acall__(self, *args: "Any", **kwargs: "Any") -> "Any":
f = self._acall_method
Expand Down
13 changes: 3 additions & 10 deletions sentry_sdk/integrations/django/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,14 @@

import sentry_sdk
from sentry_sdk.consts import OP
from sentry_sdk.integrations._asgi_common import _iscoroutinefunction

from typing import TYPE_CHECKING

if TYPE_CHECKING:
from typing import Any


try:
from asyncio import iscoroutinefunction
except ImportError:
iscoroutinefunction = None # type: ignore


try:
from sentry_sdk.integrations.django.asgi import wrap_async_view
except (ImportError, SyntaxError):
Expand Down Expand Up @@ -48,10 +43,8 @@ def sentry_patched_make_view_atomic(

integration = sentry_sdk.get_client().get_integration(DjangoIntegration)
if integration is not None:
is_async_view = (
iscoroutinefunction is not None
and wrap_async_view is not None
and iscoroutinefunction(callback)
is_async_view = wrap_async_view is not None and _iscoroutinefunction(
callback
)
if is_async_view:
sentry_wrapped_callback = wrap_async_view(callback)
Expand Down
4 changes: 2 additions & 2 deletions sentry_sdk/integrations/fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import asyncio
from copy import deepcopy
from functools import wraps

import sentry_sdk
from sentry_sdk.integrations import DidNotEnable
from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
from sentry_sdk.scope import should_send_default_pii
from sentry_sdk.traces import NoOpStreamedSpan, StreamedSpan
from sentry_sdk.tracing import SOURCE_FOR_STYLE, TransactionSource
Expand Down Expand Up @@ -74,7 +74,7 @@ def _sentry_get_request_handler(*args: "Any", **kwargs: "Any") -> "Any":
if (
dependant
and dependant.call is not None
and not asyncio.iscoroutinefunction(dependant.call)
and not _iscoroutinefunction(dependant.call)
):
old_call = dependant.call

Expand Down
6 changes: 2 additions & 4 deletions sentry_sdk/integrations/quart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import asyncio
import inspect
from functools import wraps

import sentry_sdk
from sentry_sdk.integrations import DidNotEnable, Integration
from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
from sentry_sdk.integrations._wsgi_common import _filter_headers
from sentry_sdk.integrations.asgi import SentryAsgiMiddleware
from sentry_sdk.scope import should_send_default_pii
Expand Down Expand Up @@ -106,9 +106,7 @@ def _sentry_route(*args: "Any", **kwargs: "Any") -> "Any":
old_decorator = old_route(*args, **kwargs)

def decorator(old_func: "Any") -> "Any":
if inspect.isfunction(old_func) and not asyncio.iscoroutinefunction(
old_func
):
if inspect.isfunction(old_func) and not _iscoroutinefunction(old_func):

@wraps(old_func)
@ensure_integration_enabled(QuartIntegration, old_func)
Expand Down
6 changes: 3 additions & 3 deletions sentry_sdk/integrations/starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import asyncio
import functools
import warnings
from collections.abc import Set
Expand All @@ -12,6 +11,7 @@
Integration,
_DEFAULT_FAILED_REQUEST_STATUS_CODES,
)
from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
from sentry_sdk.integrations._wsgi_common import (
DEFAULT_HTTP_METHODS_TO_CAPTURE,
HttpCodeRangeContainer,
Expand Down Expand Up @@ -424,8 +424,8 @@ def _is_async_callable(obj: "Any") -> bool:
while isinstance(obj, functools.partial):
obj = obj.func

return asyncio.iscoroutinefunction(obj) or (
callable(obj) and asyncio.iscoroutinefunction(obj.__call__)
return _iscoroutinefunction(obj) or (
callable(obj) and _iscoroutinefunction(obj.__call__)
)


Expand Down