docs: clarify Query Based Dropdown List uses cached results#855
Open
Omastto1 wants to merge 1 commit into
Open
docs: clarify Query Based Dropdown List uses cached results#855Omastto1 wants to merge 1 commit into
Omastto1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a note to the "Query Based Dropdown List" section clarifying that dropdown values come from the last cached result of the source query — the source query is not re-executed when the parent query runs.
Why
This behavior is not documented but is non-obvious and causes confusion for dropdowns that need to be updated.
latest_query_data_idisNone, the/api/queries/<id>/dropdownendpoint raises an unhandledNoResultFoundand returns a 500. The frontend silently catches it and shows "No options available" with no indication of why.query-type parameter when executing a query via the API.Evidence (from getredash/redash)
For reviewers who want to verify the claim — all paths are read-only DB lookups, no execution triggered:
redash/models/parameterized_query.py:20-29-_load_resultreadsquery.latest_query_data_idviaQueryResult.get_by_id_and_orgredash/models/parameterized_query.py:32-36-dropdown_valuesonly calls_load_resultredash/models/parameterized_query.py:160-164- parameter validation usesdropdown_values-redash/handlers/query_results.py:194-201-QueryResultDropdownResourcecallsdropdown_valuesonlyScope
Docs-only change. No code changes, no behavior changes.