Unblock HACS Hassfest by removing duplicate manifest discovery#62
Merged
Conversation
Agent-Logs-Url: https://github.com/gensyn/ssh_docker/sessions/68674cb0-d6d9-43c6-807c-42d75d888a5a Co-authored-by: gensyn <36128035+gensyn@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
gensyn
May 18, 2026 07:28
View session
There was a problem hiding this comment.
Pull request overview
This PR aims to unblock HACS/Hassfest validation by removing the Playwright fixture manifest from repository-wide *manifest.json discovery while preserving the runtime ssh_command test integration layout.
Changes:
- Renames the Playwright
ssh_commandfixture manifest tomanifest.playwright.json. - Adds a Docker Compose bind mount intended to expose that fixture as
manifest.jsoninside the Home Assistant container.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/playwright/ssh_command/manifest.playwright.json |
Provides the renamed Playwright-only ssh_command manifest fixture. |
docker-compose.yaml |
Mounts the renamed fixture back to manifest.json for the Home Assistant Playwright environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -13,6 +13,7 @@ services: | |||
| - ./:/config/custom_components/ssh_docker:ro | |||
| # Mount the ssh_command functional copy (required dependency of ssh_docker). | |||
| - ./tests/playwright/ssh_command:/config/custom_components/ssh_command:ro | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HACS admission was blocked because the
Check / Hassfestjob failed before validation:hacs/defaultscans for*manifest.jsonand aborts unless exactly one file is found. This repository included a second manifest under Playwright test fixtures, triggering that failure path.Root-cause alignment with HACS check behavior
*manifest.jsonfrom repository scan scope by renaming:tests/playwright/ssh_command/manifest.json→tests/playwright/ssh_command/manifest.playwright.jsonPreserve Playwright runtime behavior
docker-compose.yamlso the Playwright/Home Assistant test environment still sees the fixture asmanifest.jsonat runtime via bind mount:./tests/playwright/ssh_command/manifest.playwright.json:/config/custom_components/ssh_command/manifest.json:roNet effect
*manifest.jsonto HACS default checks while keeping the test fixture integration layout unchanged inside containers.