Skip to content

Arg.6 and Arg.7 Added#52

Open
zendorx wants to merge 2 commits intofriflo:mainfrom
zendorx:main
Open

Arg.6 and Arg.7 Added#52
zendorx wants to merge 2 commits intofriflo:mainfrom
zendorx:main

Conversation

@zendorx
Copy link
Copy Markdown

@zendorx zendorx commented Jan 8, 2025

I have added Arg.6 and Arg.7 and plan to add 3 more up to 10.
Please check my commits

@friflo
Copy link
Copy Markdown
Owner

friflo commented Jan 8, 2025

hi @zendorx,

massive work.
Already wrote a comment about PR's on Discord today.

"With PR's for main repo I hesitate to merge.
The main reason is I want to control the entire copyright of this project.
It allowed me to change the license to MIT in the past without being blocked by a contributor for whatever reasons.
I simply don't know how to handle this in GitHub without great circumstances so that it is legal flawless."

Beside this 8 Args is really enough. Other wise Signature gets too big.
sizeof(Signature) == 8
For 9 args it does not fit into a 64 bit and the Enumerator gets 8 bytes bigger.

@zendorx
Copy link
Copy Markdown
Author

zendorx commented Jan 8, 2025

Thank for the fast reply. I think it is enought to include some license for contributers to avoid that kind of problems (ex: https://github.com/coder/cla)

Any way I grant you any right for this code without any obligations from your side.

Beside this 8 Args is really enough. Other wise Signature gets too big.

In a big project it possible that query needed exclude or include more types than 8, so I think it there should be way to make it work.

@zendorx
Copy link
Copy Markdown
Author

zendorx commented Jan 8, 2025

@blakk-digital
Copy link
Copy Markdown

Can we ge this merged. 5 Args is very limiting. ;)

@friflo
Copy link
Copy Markdown
Owner

friflo commented Dec 27, 2025

Can we ge this merged. 5 Args is very limiting. ;)

The plan is to generate this repetitive query code. Its work in progress.
See: https://github.com/friflo/Friflo.Engine.ECS/tree/main/src/CodeGen

@blakk-digital
Copy link
Copy Markdown

Can we ge this merged. 5 Args is very limiting. ;)

The plan is to generate this repetitive query code. Its work in progress. See: https://github.com/friflo/Friflo.Engine.ECS/tree/main/src/CodeGen

Dang this is even cooler, hope to try it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants