Skip to content

feat: add semantic-release with conventional commits#212

Open
joris974 wants to merge 2 commits intomainfrom
semantic-release
Open

feat: add semantic-release with conventional commits#212
joris974 wants to merge 2 commits intomainfrom
semantic-release

Conversation

@joris974
Copy link
Copy Markdown
Member

@joris974 joris974 commented Apr 22, 2026

Summary

  • Add semantic-release configuration (.releaserc.yaml) with conventionalcommits preset, NPM publish, and GitHub release plugins
  • Add release.yml workflow using cycjimmy/semantic-release-action@v6.0.0
  • Support rc/* branches for pre-releases
  • Add RELEASE.md with conventional commit instructions
  • Add release section to README.md
  • Uses pnpm for build command in .releaserc.yaml (matching this repo's package manager)

Prerequisites

Before merging, ensure:

  • NPM_TOKEN secret is configured on the repo for NPM publishing
  • Repository rulesets have a bypass configured for the release bot (if applicable)

Test plan

  • Verify YAML syntax is valid for .releaserc.yaml and release.yml
  • Confirm CI workflow passes on this PR
  • After merge, verify a release is triggered with the feat: commit prefix
  • Test pre-release flow by pushing to an rc/* branch

Mirrors freckle/i18n-scripts-js#21

@joris974 joris974 requested a review from a team as a code owner April 22, 2026 23:40
@joris974 joris974 requested review from jleichty-ren and removed request for a team April 22, 2026 23:40
Copy link
Copy Markdown

@jleichty-ren jleichty-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like the same release setup as freckle/cancelable-promise-js#152, so the main concerns were:

  • the release config calls pnpm install && pnpm run build, but the release workflow doesn’t set up pnpm first
  • @semantic-release/git runs before @semantic-release/npm, so i’m not sure the bumped package.json would get committed back
  • if we do want to commit back to main, ${{ github.token }} may not be the right token for the repo ruleset
  • it may be worth adding "files": ["dist"] before automated publishing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants