fix: preserve all labels including invalid ones#1208
Closed
raffis wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
matheuscscp
reviewed
May 21, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
Same comments as in the other PR
Member
|
This behavior is very intentional, the SSA package is used in all controllers and this change breaks them. For the CLI we could have some validation step set there not in this package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See fluxcd/flux2#5906